Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

RUM Resources RumResourceMethod enum is missing HTTP request method names #1816

Closed
jraska opened this issue Jan 10, 2024 · 3 comments · Fixed by #1826
Closed

RUM Resources RumResourceMethod enum is missing HTTP request method names #1816

jraska opened this issue Jan 10, 2024 · 3 comments · Fixed by #1826
Labels
enhancement New feature or request

Comments

@jraska
Copy link

jraska commented Jan 10, 2024

Is your feature request related to a problem? Please describe.
Hi,

  1. RUM resources reporting introduced in October 2023 enum RumResourceMethod to constrain reported HTTP method names RUM-1236: Use enum for HTTP method parameter of RumMonitor#startResource API #1653
  2. The enum is having a subset of HTTP method names, missing TRACE, OPTIONS and CONNECT and defaulting to GET for those.
  3. The question is if this is deliberate? These methods are way less likely to be used.

Describe the solution you'd like

  • Add TRACE, OPTIONS and CONNECT method names into the RumResourceMethod and all related code as ResourceEvent and ErrorEvent.

Describe alternatives you've considered

  • Accept "GET" being reported for such methods as these method names are used rarely, but it is possible.

Additional context

@jraska jraska added the enhancement New feature or request label Jan 10, 2024
@jraska jraska changed the title RUM Resources RumResourceMethod enum is missing few HTTP request method names RUM Resources RumResourceMethod enum is missing HTTP request method names Jan 10, 2024
@0xnm
Copy link
Member

0xnm commented Jan 10, 2024

Hello @jraska!

Indeed, it is a known issue and we have it already in our backlog. No ETA for the change though, these methods are not used very frequently (and they will need changes on our backend).

@0xnm
Copy link
Member

0xnm commented Jan 17, 2024

The change will land in the 2.6.0 release.

@0xnm
Copy link
Member

0xnm commented Feb 20, 2024

The fix is a part of the 2.6.0 release.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants