Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Replace LogAttribute RUM tags in AndroidTracer with DDTags counterpart #1759

Closed

Conversation

plousada
Copy link
Member

What does this PR do?

This update the span tags pertaining RUM Context that are sent with each span.

// Before
"application_id", "session_id", "view.id", "user_action.id"

//After
"_dd.application.id", "_dd.session.id", "_dd.view.id", "_dd.action.id",

Motivation

Align with tags now used in span created from RUM Resources by RUM->APM.

Additional Notes

Anything else we should know when reviewing?

Review checklist (to be filled by reviewers)

  • Feature or bugfix MUST have appropriate tests (unit, integration, e2e)
  • Make sure you discussed the feature or bugfix with the maintaining team in an Issue
  • Make sure each commit and the PR mention the Issue number (cf the CONTRIBUTING doc)

@plousada plousada force-pushed the plousada/RUM-1912/update_span_rum_attributes branch from 722a0fe to f2cabae Compare December 11, 2023 11:38
@plousada plousada marked this pull request as ready for review December 11, 2023 12:50
@plousada plousada requested review from a team as code owners December 11, 2023 12:50
@xgouchet
Copy link
Member

Can you check if this doesn't conflict with this PR

@plousada
Copy link
Member Author

plousada commented Dec 11, 2023

Can you check if this doesn't conflict with this PR

It does, bad timing. Although that doesn't seem to cover action.id.

@plousada plousada closed this Dec 11, 2023
@xgouchet xgouchet added this to the Dropped milestone Jul 31, 2024
@xgouchet xgouchet deleted the plousada/RUM-1912/update_span_rum_attributes branch August 1, 2024 10:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants