Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

RUM-451 Update RUM attributes in spans #1758

Merged
merged 1 commit into from
Dec 11, 2023

Conversation

xgouchet
Copy link
Member

What does this PR do?

Add RUM info in new builtin attributes on spans.

Motivation

The APM UI expects RUM information to be in the following attributes in order to add a visual link to the RUM Session/View.

  • meta._dd.application.id
  • meta._dd.view.id
  • meta._dd.session.id

Additional Notes

We are still keeping the legacy attributes which already had those information for compatibility purposes (e.g.: customer using those to query/filter dashboard widgets)

@xgouchet xgouchet requested review from a team as code owners December 11, 2023 09:09
@codecov-commenter
Copy link

codecov-commenter commented Dec 11, 2023

Codecov Report

Merging #1758 (152d1ce) into develop (bece8a1) will increase coverage by 0.09%.
Report is 2 commits behind head on develop.
The diff coverage is 50.00%.

Additional details and impacted files
@@             Coverage Diff             @@
##           develop    #1758      +/-   ##
===========================================
+ Coverage    83.34%   83.42%   +0.09%     
===========================================
  Files          468      468              
  Lines        16304    16304              
  Branches      2431     2433       +2     
===========================================
+ Hits         13587    13601      +14     
+ Misses        2050     2035      -15     
- Partials       667      668       +1     
Files Coverage Δ
...e/internal/domain/event/DdSpanToSpanEventMapper.kt 94.64% <50.00%> (+2.49%) ⬆️

... and 28 files with indirect coverage changes

Copy link
Member

@0xnm 0xnm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nice!

@xgouchet xgouchet merged commit b3779e4 into develop Dec 11, 2023
23 checks passed
@xgouchet xgouchet deleted the xgouchet/RUM-451/rum_apm_attributes branch December 11, 2023 10:12
@xgouchet xgouchet added this to the 2.4.0 milestone Dec 13, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants