Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

RUMM-2380: Enable custom application version support #1026

Merged
merged 1 commit into from
Sep 1, 2022

Conversation

0xnm
Copy link
Member

@0xnm 0xnm commented Aug 31, 2022

What does this PR do?

Cherry picks #1020 into 1.14.0 release branch.

Review checklist (to be filled by reviewers)

  • Feature or bugfix MUST have appropriate tests (unit, integration, e2e)
  • Make sure you discussed the feature or bugfix with the maintaining team in an Issue
  • Make sure each commit and the PR mention the Issue number (cf the CONTRIBUTING doc)

@0xnm 0xnm requested a review from a team as a code owner August 31, 2022 09:48
@xgouchet xgouchet added the size-medium This PR is medium sized label Aug 31, 2022
@codecov-commenter
Copy link

codecov-commenter commented Aug 31, 2022

Codecov Report

Merging #1026 (b8fb0e3) into release/1.14.0 (26195cd) will increase coverage by 0.10%.
The diff coverage is 96.49%.

@@                Coverage Diff                 @@
##           release/1.14.0    #1026      +/-   ##
==================================================
+ Coverage           83.03%   83.12%   +0.10%     
==================================================
  Files                 270      272       +2     
  Lines                9249     9268      +19     
  Branches             1488     1490       +2     
==================================================
+ Hits                 7679     7704      +25     
+ Misses               1157     1156       -1     
+ Partials              413      408       -5     
Impacted Files Coverage Δ
...oid/core/internal/system/NoOpAppVersionProvider.kt 66.67% <66.67%> (ø)
...n/com/datadog/android/core/internal/CoreFeature.kt 91.56% <87.50%> (+0.04%) ⬆️
...oid/src/main/kotlin/com/datadog/android/Datadog.kt 81.97% <100.00%> (+0.45%) ⬆️
.../main/kotlin/com/datadog/android/_InternalProxy.kt 87.50% <100.00%> (-1.39%) ⬇️
.../core/internal/system/DefaultAppVersionProvider.kt 100.00% <100.00%> (ø)
...adog/android/error/internal/CrashReportsFeature.kt 100.00% <100.00%> (ø)
.../src/main/kotlin/com/datadog/android/log/Logger.kt 95.97% <100.00%> (ø)
...atadog/android/log/internal/domain/LogGenerator.kt 99.02% <100.00%> (+0.02%) ⬆️
...otlin/com/datadog/android/rum/_RumInternalProxy.kt 100.00% <100.00%> (ø)
...lin/com/datadog/android/rum/internal/RumFeature.kt 93.00% <100.00%> (+0.07%) ⬆️
... and 16 more

@0xnm 0xnm merged commit ea1cc8c into release/1.14.0 Sep 1, 2022
@0xnm 0xnm deleted the nogorodnikov/cherry-pick-custom-app-version branch September 1, 2022 13:17
@xgouchet xgouchet added this to the 1.14.0 milestone Dec 13, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
size-medium This PR is medium sized
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants