Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

RUMM-2380: Enable custom application version support #1020

Conversation

0xnm
Copy link
Member

@0xnm 0xnm commented Aug 24, 2022

What does this PR do?

This change allows to set up custom app (package) version either through internal proxy API, or through using _dd.version in the additional config. Functionally it is the same as DataDog/dd-sdk-ios#973.

This change is needed to support OTA updates in the cross-platform frameworks like React Native where cross-platform code can be update without any application restart.

Review checklist (to be filled by reviewers)

  • Feature or bugfix MUST have appropriate tests (unit, integration, e2e)
  • Make sure you discussed the feature or bugfix with the maintaining team in an Issue
  • Make sure each commit and the PR mention the Issue number (cf the CONTRIBUTING doc)

@0xnm 0xnm requested a review from a team as a code owner August 24, 2022 15:05
@codecov-commenter
Copy link

Codecov Report

Merging #1020 (ed486e6) into develop (b6e0e71) will increase coverage by 0.07%.
The diff coverage is 96.30%.

@@             Coverage Diff             @@
##           develop    #1020      +/-   ##
===========================================
+ Coverage    83.19%   83.26%   +0.07%     
===========================================
  Files          270      272       +2     
  Lines         9216     9235      +19     
  Branches      1469     1471       +2     
===========================================
+ Hits          7667     7689      +22     
+ Misses        1137     1136       -1     
+ Partials       412      410       -2     
Impacted Files Coverage Δ
...oid/core/internal/system/NoOpAppVersionProvider.kt 66.67% <66.67%> (ø)
...n/com/datadog/android/core/internal/CoreFeature.kt 91.56% <85.71%> (+0.04%) ⬆️
...oid/src/main/kotlin/com/datadog/android/Datadog.kt 81.97% <100.00%> (+0.45%) ⬆️
.../main/kotlin/com/datadog/android/_InternalProxy.kt 87.50% <100.00%> (-1.39%) ⬇️
.../core/internal/system/DefaultAppVersionProvider.kt 100.00% <100.00%> (ø)
...adog/android/error/internal/CrashReportsFeature.kt 100.00% <100.00%> (ø)
.../src/main/kotlin/com/datadog/android/log/Logger.kt 95.97% <100.00%> (ø)
...atadog/android/log/internal/domain/LogGenerator.kt 98.97% <100.00%> (+0.02%) ⬆️
...otlin/com/datadog/android/rum/_RumInternalProxy.kt 100.00% <100.00%> (ø)
...lin/com/datadog/android/rum/internal/RumFeature.kt 93.00% <100.00%> (+0.07%) ⬆️
... and 13 more

@xgouchet xgouchet added the size-medium This PR is medium sized label Aug 24, 2022
@0xnm 0xnm merged commit 1a96ca1 into develop Aug 25, 2022
@0xnm 0xnm deleted the nogorodnikov/rumm-2380/enable-custom-version-support-during-initialization branch August 25, 2022 12:29
@xgouchet xgouchet added this to the 1.15.0 milestone Dec 13, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
size-medium This PR is medium sized
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants