Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix typing on asyncio MultipartReader usage #191

Merged
merged 3 commits into from
Aug 27, 2024
Merged

Fix typing on asyncio MultipartReader usage #191

merged 3 commits into from
Aug 27, 2024

Commits on Aug 27, 2024

  1. Ignore typing on asyncio MultipartReader usage 

    aiohttp itself is ignoring some types which breaks our
type-checking (as far as I can tell).

```
    def __aiter__(
        self,
    ) -> AsyncIterator["BodyPartReader"]:
        return self  # type: ignore[return-value]
```
    @Kyle-Verhoog
    Kyle-Verhoog committed Aug 27, 2024
    Configuration menu
    Copy the full SHA
    9f88724 View commit details
    Browse the repository at this point in the history

  2. type check the body

    @Kyle-Verhoog
    Kyle-Verhoog committed Aug 27, 2024
    Configuration menu
    Copy the full SHA
    f15184a View commit details
    Browse the repository at this point in the history

  3. no ignore

    @Kyle-Verhoog
    Kyle-Verhoog committed Aug 27, 2024
    Configuration menu
    Copy the full SHA
    72bb646 View commit details
    Browse the repository at this point in the history