Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix typing on asyncio MultipartReader usage #191

Merged
merged 3 commits into from
Aug 27, 2024
Merged

Conversation

Kyle-Verhoog
Copy link
Member

aiohttp itself is ignoring some types which breaks our type-checking (as far as I can tell).

    def __aiter__(
        self,
    ) -> AsyncIterator["BodyPartReader"]:
        return self  # type: ignore[return-value]

aiohttp itself is ignoring some types which breaks our
type-checking (as far as I can tell).

```
    def __aiter__(
        self,
    ) -> AsyncIterator["BodyPartReader"]:
        return self  # type: ignore[return-value]
```
@Kyle-Verhoog Kyle-Verhoog added the no-changelog A changelog entry is not required for this PR label Aug 27, 2024
@Kyle-Verhoog Kyle-Verhoog changed the title Ignore typing on asyncio MultipartReader usage Fix typing on asyncio MultipartReader usage Aug 27, 2024
@Kyle-Verhoog Kyle-Verhoog merged commit 3775b95 into master Aug 27, 2024
11 checks passed
@Kyle-Verhoog Kyle-Verhoog deleted the fix-typing branch August 27, 2024 21:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
no-changelog A changelog entry is not required for this PR
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant