[ci] enable coverage tests 🎉 #1735
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
degemer
force-pushed
the
quentin/enable-coverage-we-can-do-it
branch
3 times, most recently
from
c58f320 to
024a76f
Compare
|
All failures are related to the "fake" metadata issue, which will be fixed by #1730 |
degemer
force-pushed
the
quentin/enable-coverage-we-can-do-it
branch
from
024a76f to
ae4c69e
Compare
|
Another step toward a robust CI 🎉 |
degemer
force-pushed
the
quentin/enable-coverage-we-can-do-it
branch
3 times, most recently
from
da64cca to
f2a27e9
Compare
In order to do this: - `elastic`: add tests for new metrics and sc from #1507 - `http_check`: add a missing service check test (`http.can_connect` is also collected when testing `http.ssl_cert`) - `disk`: 100% coverage for the 5.4.2 check (full compatibility with old check) - `lighttpd`: add two missing metrics for 100% coverage
degemer
force-pushed
the
quentin/enable-coverage-we-can-do-it
branch
from
f2a27e9 to
d8759e2
Compare
|
Failed because of the Rubygems issue, merging. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In order to do this:
elastic: add tests for new metrics from[elasticsearch] Get information about
pending_tasks#1507http_check: add a missing service check test (http.can_connectis alsocollected when testing
http.ssl_cert)disk: 100% coverage for the 5.4.2 check (full compatibility with old check)lighttpd: add two missing metrics for 100% coverageWaiting on #1730 for the coverage metadata fix.