[ci] windows tests with appveyor #1730
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
degemer
force-pushed
the
quentin/appveyor
branch
5 times, most recently
from
26a55d5 to
08ac524
Compare
| # checks.d/wmi.py | ||
| # It's a pure python module, it doesn't require anything to install, | ||
| # but needs the pywin32 extension to work | ||
| wmi==1.4.9 |
There was a problem hiding this comment.
Shall we remove it from here then https://github.com/DataDog/dd-agent/blob/master/setup.py#L43 ?
|
Great PR !!! 👊 in Windows CI process. 🍰 for you Windows Powershell skills. |
All parameters are in `appveyor.yml`.
This CI use the exact same syntax/functions as Travis one.
To run tests only requiring the Windows OS, add two attributes,
`@attr('windows')` and `@attr(requires='windows')`, they will be picked by
`ci/windows.rb`.
Adding new flavors is exactly the same as Travis, but instead of updating the
`.travis.yml`, update `appveyor.yml`.
Also: install pywin32 (not done by default)
+ a fix for coverage tests. They were broken by a change introduced by service metadata (all instances have at least an empty metadata). It's removed in tests now.
- Add `wmi` to requirements-opt - enable coverage report on Windows
Mainly for the download of pywin32
degemer
force-pushed
the
quentin/appveyor
branch
from
08ac524 to
7aa35ce
Compare
|
Thanks for the review ! I addressed your comments and merged. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds a Windows-compatibility layer to our CI framework to be able to test Windows checks.
It also add tests for
win32_event_logcheck.See commits for more details.