changed 'task name' of workflow-level errors (#632)

DataBiosphere · Apr 25, 2019 · 3c782d0 · 3c782d0
1 parent bdbb64d
commit 3c782d0
Show file tree

Hide file tree

Showing 3 changed files with 5 additions and 2 deletions.
diff --git a/CHANGELOG.md b/CHANGELOG.md
@@ -2,11 +2,14 @@
 
 ## v0.7.2 Release Notes
 
+### Improved the clarity of workflow-level errors.
+
 ### Fixed incorrectly translated job attempt status from Cromwell backend.
 
 ### Fixed incorrect tooltip for standard out log.
 
 ### Added customized favicon.
+>>>>>>> master
 
 ## v0.7.1 Release Notes
 

diff --git a/servers/cromwell/jobs/controllers/jobs_controller.py b/servers/cromwell/jobs/controllers/jobs_controller.py
@@ -221,7 +221,7 @@ def format_task_failure(task_name, metadata):
 
 
 def format_workflow_failure(failures):
-    return FailureMessage(task_name=failures.get('message'),
+    return FailureMessage('Workflow Error',
                           failure=failures.get('causedBy')[0].get('message'))
 
 

diff --git a/servers/cromwell/jobs/test/test_jobs_controller.py b/servers/cromwell/jobs/test/test_jobs_controller.py
@@ -438,7 +438,7 @@ def _request_callback(request, context):
             },
             'failures': [{
                 'failure': 'Task test.analysis failed',
-                'taskName': 'Workflow failed'
+                'taskName': 'Workflow Error'
             }]
         }  # yapf: disable
         self.assertDictEqual(response_data, expected_data)