fixed incorrect map of Cromwell status to UI status (#631)

DataBiosphere · Apr 25, 2019 · bdbb64d · bdbb64d
1 parent 9bc0e01
commit bdbb64d
Show file tree

Hide file tree

Showing 3 changed files with 4 additions and 2 deletions.
diff --git a/CHANGELOG.md b/CHANGELOG.md
@@ -2,6 +2,8 @@
 
 ## v0.7.2 Release Notes
 
+### Fixed incorrectly translated job attempt status from Cromwell backend.
+
 ### Fixed incorrect tooltip for standard out log.
 
 ### Added customized favicon.

diff --git a/servers/cromwell/jobs/controllers/utils/task_statuses.py b/servers/cromwell/jobs/controllers/utils/task_statuses.py
@@ -33,7 +33,7 @@
     CromwellExecutionStatus.UNSTARTABLE: ApiStatus.FAILED,
     CromwellExecutionStatus.ABORTED: ApiStatus.ABORTED,
     CromwellExecutionStatus.BYPASSED: ApiStatus.SUBMITTED,
-    CromwellExecutionStatus.RETRYABLEFAILURE: ApiStatus.RUNNING,
+    CromwellExecutionStatus.RETRYABLEFAILURE: ApiStatus.FAILED,
     CromwellExecutionStatus.FAILED: ApiStatus.FAILED,
     CromwellExecutionStatus.DONE: ApiStatus.SUCCEEDED
 }

diff --git a/servers/cromwell/jobs/test/test_task_statuses.py b/servers/cromwell/jobs/test/test_task_statuses.py
@@ -23,7 +23,7 @@ def test_cromwell_execution_to_api_maps_all_task_execution_statuses_correctly(se
         self.assertEqual(task_statuses.cromwell_execution_to_api('Unstartable'), 'Failed')
         self.assertEqual(task_statuses.cromwell_execution_to_api('Aborted'), 'Aborted')
         self.assertEqual(task_statuses.cromwell_execution_to_api('Bypassed'), 'Submitted')
-        self.assertEqual(task_statuses.cromwell_execution_to_api('RetryableFailure'), 'Running')
+        self.assertEqual(task_statuses.cromwell_execution_to_api('RetryableFailure'), 'Failed')
         self.assertEqual(task_statuses.cromwell_execution_to_api('Failed'), 'Failed')
         self.assertEqual(task_statuses.cromwell_execution_to_api('Done'), 'Succeeded')
     # yapf: enable