Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve traditional installation guide #22

Merged
merged 9 commits into from
Sep 20, 2024

Conversation

siggmo
Copy link
Collaborator

@siggmo siggmo commented Sep 9, 2024

Closes #16

Essentially I resembled the steps from our fans-dev Dockerfile.

@siggmo siggmo linked an issue Sep 9, 2024 that may be closed by this pull request
@IshaanDesai IshaanDesai added the documentation Improvements or additions to documentation label Sep 10, 2024
@sanathkeshav sanathkeshav self-requested a review September 10, 2024 08:46
README.md Outdated Show resolved Hide resolved
README.md Outdated Show resolved Hide resolved
README.md Outdated Show resolved Hide resolved
Copy link
Collaborator

@IshaanDesai IshaanDesai left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Some minor suggestions from my side.

@sanathkeshav sanathkeshav self-requested a review September 10, 2024 09:10
Copy link
Collaborator

@IshaanDesai IshaanDesai left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I reworked many parts of the README. From my side, it looks good to go 👍

Copy link
Member

@sanathkeshav sanathkeshav left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

some small changes

README.md Show resolved Hide resolved
README.md Show resolved Hide resolved
README.md Outdated Show resolved Hide resolved
README.md Show resolved Hide resolved
@IshaanDesai IshaanDesai merged commit 528e517 into develop Sep 20, 2024
7 checks passed
@IshaanDesai IshaanDesai deleted the feature/improve-installation-guide branch September 20, 2024 19:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
documentation Improvements or additions to documentation
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Improvement to traditional installation guidelines
3 participants