Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Port main] Hide search text field when number of facet values is less than the maximum #3097

Merged
merged 4 commits into from
May 31, 2024
Merged

[Port main] Hide search text field when number of facet values is less than the maximum #3097

merged 4 commits into from
May 31, 2024

Conversation

tdonohue
Copy link
Member

Manual port of #3061 by @VictorHugoDuranS to main branch.

VictorHugoDuranS and others added 3 commits May 31, 2024 12:30
@VictorHugoDuranS @tdonohue
Fix - hide search text field in the filter section if the number of f…
906b2f5 
…acet values does not exceed the maximum number of facet values shown
@VictorHugoDuranS @tdonohue
Fix - hide search text field in the filter section if the number of f…
44480cb 
…acet values does not exceed the maximum number of facet values shown
@tdonohue
Fix "Async pipe results should not be negated" from lint
e3595e5
@tdonohue tdonohue added bug component: Discovery related to discovery search or browse system 1 APPROVAL pull request only requires a single approval to merge labels May 31, 2024
@tdonohue tdonohue added this to the 8.0 milestone May 31, 2024
tdonohue
tdonohue commented May 31, 2024
View reviewed changes
Copy link
Member Author

@tdonohue tdonohue left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍 I've manually tested this port and it has the same behavior as the original #3061 PR.

@tdonohue tdonohue mentioned this pull request May 31, 2024
Merged
8 tasks
@tdonohue tdonohue merged commit b0a8a50 into DSpace:main May 31, 2024
11 checks passed
@tdonohue tdonohue deleted the port_3061_to_main branch May 31, 2024 19:38
@tdonohue tdonohue mentioned this pull request May 31, 2024
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@tdonohue tdonohue

Labels
1 APPROVAL pull request only requires a single approval to merge bug component: Discovery related to discovery search or browse system
Projects
No open projects
DSpace 8.0 Release
Status: ✅ Done
Milestone
8.0
Development

Successfully merging this pull request may close these issues.
2 participants
@tdonohue @VictorHugoDuranS