hide search text field in the filter section if the number of facet values does not exceed the maximum number of facet values shown

[saschaszott]

The search text field below the facet values is not necessary if all facet values are shown, i.e. the current number of facet values does not exceed the maximum number of facet values that can be shown in a filter section. The red marked text fields in the screenshot can be omitted.

[floriangantner]

We've solved the problem on our running dspace-cris instance by only showing the suggestions if the lastPage of the facet values entries is not reached <ds-filter-input-suggestions *ngIf="!(isLastPage$ | async)" [suggestions]="(filterSearchResults | async)". This should concern

dspace-angular/src/app/shared/search/search-filters/search-filter/search-text-filter/search-text-filter.component.html

Line 20 in c4342d3

<ds-filter-input-suggestions [suggestions]="(filterSearchResults | async)"

,

dspace-angular/src/app/shared/search/search-filters/search-filter/search-hierarchy-filter/search-hierarchy-filter.component.html

Line 20 in c4342d3

<ds-filter-input-suggestions [suggestions]="(filterSearchResults | async)"

and

dspace-angular/src/app/shared/search/search-filters/search-filter/search-authority-filter/search-authority-filter.component.html

Line 20 in c4342d3

<ds-filter-input-suggestions [suggestions]="(filterSearchResults | async)"

. If no other volunteer has some better solution/idea we might take over this job. :)

[tdonohue]

Closing, fixed by #3061 (for 7.x) and #3097 (for 8.x)