[2185] Fix delete review app #3331
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Obtain it dynamically so we don't need to maintain it
|
Review app deployed to https://get-school-experience-review-pr-3331.test.teacherservices.cloud |
RMcVelia
approved these changes
Dec 16, 2024
saliceti
deleted the
2185-school-experience-failure-to-delete-review-app
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Trello card
https://trello.com/c/N2pyTDQX
Context
Fix failure: https://github.com/DFE-Digital/schools-experience/actions/runs/12313465305/job/34368621076
Changes proposed in this pull request
Stop using out of data storage key secret. Retrieve the key dynamically instead.
Guidance to review
Successful run after closing PR: https://github.com/DFE-Digital/schools-experience/actions/runs/12351146158/job/34465482506