Merge pull request #3331 from DFE-Digital/2185-school-experience-fail…

…ure-to-delete-review-app

[2185] Fix delete review app

.github/workflows/destroy.yml

@@ -55,5 +55,11 @@ jobs:
         run: |
             make ci review terraform-destroy PR_NUMBER=${{github.event.number}}
 
+      - name: Set Container Access Key
+        run: |
+          TFSTATE_CONTAINER_ACCESS_KEY="$(az storage account keys list -g s189t01-gse-rv-rg -n s189t01gsetfstatervsa | jq -r '.[0].value')"
+          echo "::add-mask::$TFSTATE_CONTAINER_ACCESS_KEY"
+          echo "TFSTATE_CONTAINER_ACCESS_KEY=$TFSTATE_CONTAINER_ACCESS_KEY" >> $GITHUB_ENV
+
       - name: Delete Terraform State File
-        run:  az storage blob delete --container-name  terraform-state --account-name s189t01gsetfstatervsa --account-key ${{secrets.ARM_ACCESS_KEY}} -n ${{github.event.number}}_kubernetes.tfstate
+        run:  az storage blob delete --container-name  terraform-state --account-name s189t01gsetfstatervsa --account-key ${TFSTATE_CONTAINER_ACCESS_KEY} -n ${{github.event.number}}_kubernetes.tfstate

docs/documents/DevOps/tools/trello.md

@@ -17,7 +17,7 @@ In School Experience there is a workflow which uses the [Github Action](https://
 [Get School Experience](https://trello.com/b/nS4OTSIl/get-school-experience)
 
 ## Change Key
-The trello keys are linked to the service account schoolexperience-tech@digital.education.gov.uk. The email is a Google group and the trello password
+The trello keys are linked to the service account schoolexperience-tech@digital.education.gov.uk. The email is a 365 distribution list and the trello password
 is kept in azure key vault s105p01-kv. To generate the API key and token, follow the instructions on [Developer API Keys](https://trello.com/app-key).
 
 Then once you have them, use the command `make development edit-infra-secrets` to edit your secrets and store them in Azure key vault.

docs/documents/DevOps/workflows.md

@@ -31,9 +31,6 @@ This is the heart of the deployment system, it has a number of phases
 	8. **Quality Assurance** - Also known as the staging area, this is a near live test, ensuring all the components hang together, so there is a high degree of confidence the Production deployment will work.
 	9. **Production** - The final deployment to the live system
 
-### [Check Service Principal](https://github.com/DFE-Digital/schools-experience/blob/master/.github/workflows/check_sp.yml)
-Ran each night this workflow checks that Service Prinicipal has at least 30 days left before its security credentials expire. If due to expire a message is sent to [SLACK](https://slack.com) with instructions on how to reset it.
-
 ### [DO NOT MERGE](https://github.com/DFE-Digital/schools-experience/blob/master/.github/workflows/stop_merges.yml)
 When a PR is labelled with DO NOT MERGE, this workflow will prevent the system from merging it.