🍀 Four kinds of init error #54
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
duncanjbrown
changed the title
duncanjbrown
changed the title
duncanjbrown
force-pushed
the
test-migration-recovery
branch
2 times, most recently
from
ba6f618 to
592bdd1
Compare
- ActiveRecord::SchemaMigrations and internal_metadata tables are being considered for dfe-analytics (ignore them) - discovering migrations pending on dfe-analytics init no longer bails pre-emptively - discovering missing database connection when database not present, also on init, also no longer bails pre-emptively - don't eager load unless we've got a database connection The final example is important because some contexts which lack db connections (eg asset precompilation) also don't provide all necessary eg ENV vars which would be required were we loading the whole app (which this init process does). So discover early if we have no database (call ActiveRecord::Base.connection). & if anything happens during Fields.check! catch that too. Log lines will tell us if we're bailing for want of a DB or for want of a migration. (There's no point in running check! if migration yet to run).
duncanjbrown
force-pushed
the
test-migration-recovery
branch
from
592bdd1 to
4e2e86b
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
4️⃣ error conditions we discovered during recent rollout in Publish and Apply CI pipelines.
The final example is important because some contexts which lack db connections (eg asset precompilation) also don't provide all necessary eg ENV vars which would be required were we loading the whole app (which this init process does).
So discover early if we have no database (call
ActiveRecord::Base.connection). & if anything happens during Fields.check! catch that too. Log lines will tell us if we're bailing for want of a DB or for want of a migration. (There's no point in running check! if migration yet to run).