Bump dfe-analytics from v1.3.2 to v1.5.2

[dependabot]

Bumps dfe-analytics from v1.3.2 to v1.5.0.

Changelog

Sourced from dfe-analytics's changelog.

v1.5.0 (2022-09-22)

Full Changelog

Merged pull requests:

• ignore version release PRs in changelog #49 (misaka)
• Run specs on multiple Rails versions #48 (duncanjbrown)
• Change ActiveJob log level #47 (duncanjbrown)
• README updates covering PII and queues #46 (slorek)
• Make backfill resilient #45 (duncanjbrown)

v1.4.0 (2022-08-31)

Full Changelog

Merged pull requests:

• Pass model names as strings when loading batches #43 (duncanjbrown)
• allow user id field to be configurable #42 (misaka)
• add GCloud install details and move to new file #41 (misaka)
• Add gcloud cli instructions for roles #40 (misaka)
• Initialize model callbacks on boot #37 (duncanjbrown)
• Adopt with_model #36 (duncanjbrown)

Commits

• 950d115 v1.5.0
• 8a181ff Merge pull request #45 from DFE-Digital/backfill
• d674ccc Merge pull request #44 from DFE-Digital/v1.4.0-release
• 01292ec Merge pull request #49 from DFE-Digital/ignore-version-release-prs
• 25d6886 ignore version release PRs in changelog
• 0f356a8 update changelog for v1.4.0
• ef833c7 Merge pull request #46 from DFE-Digital/readme-change
• a25f1fa Update README.md
• e7e55e8 Fix an order-dependent spec failure
• ef231aa Batch events in a way that is sensitive to BQ quotas
• Additional commits viewable in compare view

Dependabot will resolve any conflicts with this PR as long as you don't alter it yourself. You can also trigger a rebase manually by commenting @dependabot rebase.

---

Dependabot commands and options

You can trigger Dependabot actions by commenting on this PR:

• @dependabot rebase will rebase this PR
• @dependabot recreate will recreate this PR, overwriting any edits that have been made to it
• @dependabot merge will merge this PR after your CI passes on it
• @dependabot squash and merge will squash and merge this PR after your CI passes on it
• @dependabot cancel merge will cancel a previously requested merge and block automerging
• @dependabot reopen will reopen this PR if it is closed
• @dependabot close will close this PR and stop Dependabot recreating it. You can achieve the same result by closing it manually
• @dependabot ignore this major version will close this PR and stop Dependabot creating any more for this major version (unless you reopen the PR or upgrade to it yourself)
• @dependabot ignore this minor version will close this PR and stop Dependabot creating any more for this minor version (unless you reopen the PR or upgrade to it yourself)
• @dependabot ignore this dependency will close this PR and stop Dependabot creating any more for this dependency (unless you reopen the PR or upgrade to it yourself)

[elliotcm]

@dependabot rebase

[elliotcm]

It looks like a significant (technically non-breaking) change happened where they now autosubmit whitelisted models to analytics.

The problem comes because as part of this change they now eager load our entire application:
https://github.com/DFE-Digital/dfe-analytics/blob/main/lib/dfe/analytics.rb#L171
which then loads classes which previously would not have been loaded, like the REST-based ones, at least one of which relies on an environment variable:
https://github.com/DFE-Digital/apply-for-teacher-training/blob/main/app/models/teacher_training_public_api/resource.rb#L3

This means that any CI builds that don't specify that key now explode.
https://github.com/DFE-Digital/apply-for-teacher-training/actions/runs/3127860356/jobs/5074978990#step:12:1053

We could add the key, perhaps, or ask @duncanjbrown whether there's an alternate approach that could be used in the analytics gem.

[duncanjbrown]

Thanks for detailed report @elliotcm — having a look!

[duncanjbrown]

I think this is failing not for want of an env var, but for want of a database at asset precompilation, which we fixed at 1.5.1. (Existing tests do run those ENV-requiring classes.)

Bumping to 1.5.1 to see if that fixes things

[duncanjbrown]

we behave badly when there's a migration pending (eg when deploying to review apps) — trying a patch in the gem

[dependabot]

A newer version of dfe-analytics exists, but since this PR has been edited by someone other than Dependabot I haven't updated it. You'll get a PR for the updated version as normal once this PR is merged.

[duncanjbrown]

Progress — but test DB setup is now not working. Investigating further.

[duncanjbrown]

OK it's building. @elliotcm you were right about that ENV var — for some reason I got a different error when I ran! But then I got the env var error again. In the process of fixing it over here — DFE-Digital/dfe-analytics#54. Once that's released I'll fix up this PR, which is now building

[github-actions]

Database-level enum changes detected

Please include a data migration for these attributes and values:

4,5c4,23
< <enum> ApplicationChoice.status: ["unsubmitted", "cancelled", "awaiting_provider_decision", "interviewing", "offer", "pending_conditions", "recruited", "rejected", "application_not_sent", "offer_withdrawn", "declined", "withdrawn", "conditions_not_met", "offer_deferred"]
< <enum> ApplicationChoice.rejection_reasons_type: ["rejection_reason", "reasons_for_rejection", "rejection_reasons", "vendor_api_rejection_reasons"]
---
> <enum> Vendor.name: ["tribal", "ellucian", "oracle", "unit4", "capita", "in_house"]
> <enum> ValidationError.service: ["apply", "manage"]
> <enum> Provider.region_code: ["east_midlands", "eastern", "london", "no_region", "north_east", "north_west", "scotland", "south_east", "south_west", "wales", "west_midlands", "yorkshire_and_the_humber"]
> <enum> OfferCondition.status: ["pending", "met", "unmet"]
> <enum> EnglishProficiency.qualification_status: ["has_qualification", "no_qualification", "qualification_not_needed"]
> <enum> Email.delivery_status: ["not_tracked", "notify_error", "pending", "skipped", "unknown", "delivered", "permanent_failure", "temporary_failure", "technical_failure"]
> <enum> DataExport.export_type: ["active_provider_user_permissions", "active_provider_users", "applications_by_demographic_domicile_and_degree_class", "applications_by_subject_route_and_degree_grade", "application_references", "application_timings", "application_timings_for_current_cycle", "candidate_application_feedback", "candidate_autosuggest_usage", "candidate_email_send_counts", "candidate_feedback", "candidate_journey_tracking", "candidate_course_choice_withdrawal_survey", "equality_and_diversity", "external_report_applications", "external_report_candidates", "find_feedback", "interview_export", "ministerial_report_applications_export", "ministerial_report_candidates_export", "notifications_export", "notification_preferences_export", "notes_export", "offer_conditions", "organisation_permissions", "provider_access_controls", "providers_export", "persona_export", "qualifications", "referee_survey", "sites_export", "structured_reasons_for_rejection", "submitted_application_choices", "submitted_application_choices_for_current_cycle", "tad_applications", "tad_provider_performance", "tad_subject_domicile_nationality", "user_permissions", "who_ran_which_export", "work_history_break"]
> <enum> CourseOption.vacancy_status: ["vacancies", "no_vacancies"]
> <enum> CourseOption.study_mode: ["full_time", "part_time"]
> <enum> Course.level: ["Primary", "Secondary", "Further education"]
> <enum> Course.study_mode: ["F", "P", "B"]
> <enum> Course.funding_type: ["fee", "salary", "apprenticeship"]
> <enum> Course.program_type: ["HE", "SD", "SS", "SC", "TA"]
> <enum> Course.degree_grade: ["two_one", "two_two", "third_class", "not_required"]
> <enum> ChaserSent.chaser_type: ["reference_request", "referee_reference_request", "candidate_reference_request", "reference_replacement", "follow_up_missing_references", "candidate_follow_up_missing_references", "referee_follow_up_missing_references", "reminder_reference_nudge", "provider_decision_request", "candidate_decision_request", "course_unavailable_notification", "course_unavailable_slack_notification", "eoc_deadline_reminder", "find_has_opened", "new_cycle_has_started", "set_up_organisation_permissions", "apply_service_is_now_open", "find_service_is_now_open", "apply_service_open_organisation_notification", "find_service_open_organisation_notification"]
> <enum> ApplicationReference.feedback_status: ["cancelled", "cancelled_at_end_of_cycle", "not_requested_yet", "feedback_requested", "feedback_provided", "feedback_refused", "email_bounced"]
> <enum> ApplicationReference.referee_type: ["academic", "professional", "school-based", "character"]
> <enum> ApplicationReference.safeguarding_concerns_status: ["not_answered_yet", "no_safeguarding_concerns_to_declare", "has_safeguarding_concerns_to_declare", "never_asked"]
> <enum> ApplicationQualification.level: ["degree", "gcse", "other"]
> <enum> ApplicationQualification.comparable_uk_degree: ["bachelor_ordinary_degree", "bachelor_honours_degree", "postgraduate_certificate_or_diploma", "masters_degree", "doctor_of_philosophy", "post_doctoral_award"]
14,33c32,33
< <enum> ApplicationQualification.level: ["degree", "gcse", "other"]
< <enum> ApplicationQualification.comparable_uk_degree: ["bachelor_ordinary_degree", "bachelor_honours_degree", "postgraduate_certificate_or_diploma", "masters_degree", "doctor_of_philosophy", "post_doctoral_award"]
< <enum> ApplicationReference.feedback_status: ["cancelled", "cancelled_at_end_of_cycle", "not_requested_yet", "feedback_requested", "feedback_provided", "feedback_refused", "email_bounced"]
< <enum> ApplicationReference.referee_type: ["academic", "professional", "school-based", "character"]
< <enum> ApplicationReference.safeguarding_concerns_status: ["not_answered_yet", "no_safeguarding_concerns_to_declare", "has_safeguarding_concerns_to_declare", "never_asked"]
< <enum> ChaserSent.chaser_type: ["reference_request", "referee_reference_request", "candidate_reference_request", "reference_replacement", "follow_up_missing_references", "candidate_follow_up_missing_references", "referee_follow_up_missing_references", "reminder_reference_nudge", "provider_decision_request", "candidate_decision_request", "course_unavailable_notification", "course_unavailable_slack_notification", "eoc_deadline_reminder", "find_has_opened", "new_cycle_has_started", "set_up_organisation_permissions", "apply_service_is_now_open", "find_service_is_now_open", "apply_service_open_organisation_notification", "find_service_open_organisation_notification"]
< <enum> Course.level: ["Primary", "Secondary", "Further education"]
< <enum> Course.study_mode: ["F", "P", "B"]
< <enum> Course.funding_type: ["fee", "salary", "apprenticeship"]
< <enum> Course.program_type: ["HE", "SD", "SS", "SC", "TA"]
< <enum> Course.degree_grade: ["two_one", "two_two", "third_class", "not_required"]
< <enum> CourseOption.vacancy_status: ["vacancies", "no_vacancies"]
< <enum> CourseOption.study_mode: ["full_time", "part_time"]
< <enum> DataExport.export_type: ["active_provider_user_permissions", "active_provider_users", "applications_by_demographic_domicile_and_degree_class", "applications_by_subject_route_and_degree_grade", "application_references", "application_timings", "application_timings_for_current_cycle", "candidate_application_feedback", "candidate_autosuggest_usage", "candidate_email_send_counts", "candidate_feedback", "candidate_journey_tracking", "candidate_course_choice_withdrawal_survey", "equality_and_diversity", "external_report_applications", "external_report_candidates", "find_feedback", "interview_export", "ministerial_report_applications_export", "ministerial_report_candidates_export", "notifications_export", "notification_preferences_export", "notes_export", "offer_conditions", "organisation_permissions", "provider_access_controls", "providers_export", "persona_export", "qualifications", "referee_survey", "sites_export", "structured_reasons_for_rejection", "submitted_application_choices", "submitted_application_choices_for_current_cycle", "tad_applications", "tad_provider_performance", "tad_subject_domicile_nationality", "user_permissions", "who_ran_which_export", "work_history_break"]
< <enum> Email.delivery_status: ["not_tracked", "notify_error", "pending", "skipped", "unknown", "delivered", "permanent_failure", "temporary_failure", "technical_failure"]
< <enum> EnglishProficiency.qualification_status: ["has_qualification", "no_qualification", "qualification_not_needed"]
< <enum> OfferCondition.status: ["pending", "met", "unmet"]
< <enum> Provider.region_code: ["east_midlands", "eastern", "london", "no_region", "north_east", "north_west", "scotland", "south_east", "south_west", "wales", "west_midlands", "yorkshire_and_the_humber"]
< <enum> ValidationError.service: ["apply", "manage"]
< <enum> Vendor.name: ["tribal", "ellucian", "oracle", "unit4", "capita", "in_house"]
---
> <enum> ApplicationChoice.status: ["unsubmitted", "cancelled", "awaiting_provider_decision", "interviewing", "offer", "pending_conditions", "recruited", "rejected", "application_not_sent", "offer_withdrawn", "declined", "withdrawn", "conditions_not_met", "offer_deferred"]
> <enum> ApplicationChoice.rejection_reasons_type: ["rejection_reason", "reasons_for_rejection", "rejection_reasons", "vendor_api_rejection_reasons"]

[carlosmartinez]

@duncanjbrown any progress on this, guvnor?

[duncanjbrown]

oh — yes! fixing 'er up now