1765: use vt compilation flags for bundled libraries as well #1776

cz4rs · 2022-05-05T18:08:22Z

github-actions · 2022-05-05T18:23:03Z

PR tests (gcc-9, ubuntu, mpich, zoltan)

Build for 54bd0fd

Compilation - successful

Testing - passed

Build log

github-actions · 2022-05-05T18:24:14Z

PR tests (gcc-5, ubuntu, mpich)

Build for 54bd0fd

Compilation - successful

Testing - passed

Build log

github-actions · 2022-05-05T18:25:35Z

PR tests (clang-10, ubuntu, mpich)

Build for 54bd0fd

Compilation - successful

Testing - passed

Build log

github-actions · 2022-05-05T18:25:43Z

PR tests (nvidia cuda 10.1, ubuntu, mpich)

Build for 54bd0fd

Compilation - successful

Testing - passed

Build log

github-actions · 2022-05-05T18:25:47Z

PR tests (clang-3.9, ubuntu, mpich)

Build for 54bd0fd

Compilation - successful

Testing - passed

Build log

github-actions · 2022-05-05T18:27:33Z

PR tests (clang-9, ubuntu, mpich)

Build for 54bd0fd

Compilation - successful

Testing - passed

Build log

github-actions · 2022-05-05T18:28:19Z

PR tests (clang-5.0, ubuntu, mpich)

Build for 54bd0fd

Compilation - successful

Testing - passed

Build log

github-actions · 2022-05-05T18:28:45Z

PR tests (gcc-6, ubuntu, mpich)

Build for 54bd0fd

Compilation - successful

Testing - passed

Build log

github-actions · 2022-05-05T18:30:20Z

PR tests (gcc-8, ubuntu, mpich, address sanitizer)

Build for 54bd0fd

Compilation - successful

Testing - passed

Build log

github-actions · 2022-05-05T18:30:23Z

PR tests (nvidia cuda 11.0, ubuntu, mpich)

Build for 54bd0fd

Compilation - successful

Testing - passed

Build log

github-actions · 2022-05-05T18:30:41Z

PR tests (clang-10, alpine, mpich)

Build for 54bd0fd

Compilation - successful

Testing - passed

Build log

github-actions · 2022-05-05T18:31:56Z

PR tests (intel icpx, ubuntu, mpich)

Build for 54bd0fd

Compilation - successful

Testing - passed

Build log

github-actions · 2022-05-05T18:32:06Z

PR tests (gcc-10, ubuntu, openmpi, no LB)

Build for 54bd0fd

Compilation - successful

Testing - passed

Build log

github-actions · 2022-05-05T18:32:31Z

PR tests (gcc-7, ubuntu, mpich, trace runtime, LB)

Build for 54bd0fd

Compilation - successful

Testing - passed

Build log

github-actions · 2022-05-05T18:33:25Z

PR tests (clang-11, ubuntu, mpich)

Build for 54bd0fd

In file included from src/CMakeFiles/vt.dir/Unity/unity_14_cxx.cxx:7:
/vt/src/vt/utils/memory/memory_usage.cc:149:26: warning: 'mallinfo' is deprecated [-Wdeprecated-declarations]
    struct mallinfo mi = mallinfo();
                         ^
/usr/include/malloc.h:114:48: note: 'mallinfo' has been explicitly marked deprecated here
extern struct mallinfo mallinfo (void) __THROW __MALLOC_DEPRECATED;
                                               ^
/usr/include/malloc.h:32:30: note: expanded from macro '__MALLOC_DEPRECATED'
# define __MALLOC_DEPRECATED __attribute_deprecated__
                             ^
/usr/include/x86_64-linux-gnu/sys/cdefs.h:339:51: note: expanded from macro '__attribute_deprecated__'
# define __attribute_deprecated__ __attribute__ ((__deprecated__))
                                                  ^
1 warning generated.

Testing - passed

Build log

github-actions · 2022-05-05T18:35:49Z

PR tests (clang-12, ubuntu, mpich)

Build for 54bd0fd

In file included from src/CMakeFiles/vt.dir/Unity/unity_14_cxx.cxx:7:
/vt/src/vt/utils/memory/memory_usage.cc:149:26: warning: 'mallinfo' is deprecated [-Wdeprecated-declarations]
    struct mallinfo mi = mallinfo();
                         ^
/usr/include/malloc.h:114:48: note: 'mallinfo' has been explicitly marked deprecated here
extern struct mallinfo mallinfo (void) __THROW __MALLOC_DEPRECATED;
                                               ^
/usr/include/malloc.h:32:30: note: expanded from macro '__MALLOC_DEPRECATED'
# define __MALLOC_DEPRECATED __attribute_deprecated__
                             ^
/usr/include/x86_64-linux-gnu/sys/cdefs.h:339:51: note: expanded from macro '__attribute_deprecated__'
# define __attribute_deprecated__ __attribute__ ((__deprecated__))
                                                  ^
1 warning generated.

Testing - passed

Build log

github-actions · 2022-05-05T18:36:39Z

PR tests (gcc-11, ubuntu, mpich)

Build for 54bd0fd

In file included from src/CMakeFiles/vt.dir/Unity/unity_14_cxx.cxx:7:
/vt/src/vt/utils/memory/memory_usage.cc: In member function 'virtual std::size_t vt::util::memory::Mallinfo::getUsage()':
/vt/src/vt/utils/memory/memory_usage.cc:149:34: warning: 'mallinfo mallinfo()' is deprecated [-Wdeprecated-declarations]
  149 |     struct mallinfo mi = mallinfo();
      |                          ~~~~~~~~^~
In file included from /vt/src/vt/utils/memory/memory_usage.cc:59,
                 from src/CMakeFiles/vt.dir/Unity/unity_14_cxx.cxx:7:
/usr/include/malloc.h:114:24: note: declared here
  114 | extern struct mallinfo mallinfo (void) __THROW __MALLOC_DEPRECATED;
      |                        ^~~~~~~~

Testing - passed

Build log

github-actions · 2022-05-05T18:37:27Z

PR tests (clang-13, ubuntu, mpich)

Build for 54bd0fd

In file included from src/CMakeFiles/vt.dir/Unity/unity_14_cxx.cxx:7:
/vt/src/vt/utils/memory/memory_usage.cc:149:26: warning: 'mallinfo' is deprecated [-Wdeprecated-declarations]
    struct mallinfo mi = mallinfo();
                         ^
/usr/include/malloc.h:114:48: note: 'mallinfo' has been explicitly marked deprecated here
extern struct mallinfo mallinfo (void) __THROW __MALLOC_DEPRECATED;
                                               ^
/usr/include/malloc.h:32:30: note: expanded from macro '__MALLOC_DEPRECATED'
# define __MALLOC_DEPRECATED __attribute_deprecated__
                             ^
/usr/include/x86_64-linux-gnu/sys/cdefs.h:339:51: note: expanded from macro '__attribute_deprecated__'
# define __attribute_deprecated__ __attribute__ ((__deprecated__))
                                                  ^
1 warning generated.

Testing - passed

Build log

github-actions · 2022-05-05T18:37:58Z

PR tests (gcc-12, ubuntu, mpich)

Build for 54bd0fd

In file included from src/CMakeFiles/vt.dir/Unity/unity_14_cxx.cxx:7:
/vt/src/vt/utils/memory/memory_usage.cc: In member function 'virtual std::size_t vt::util::memory::Mallinfo::getUsage()':
/vt/src/vt/utils/memory/memory_usage.cc:149:34: warning: 'mallinfo mallinfo()' is deprecated [-Wdeprecated-declarations]
  149 |     struct mallinfo mi = mallinfo();
      |                          ~~~~~~~~^~
In file included from /vt/src/vt/utils/memory/memory_usage.cc:59:
/usr/include/malloc.h:114:24: note: declared here
  114 | extern struct mallinfo mallinfo (void) __THROW __MALLOC_DEPRECATED;
      |                        ^~~~~~~~

Testing - passed

Build log

github-actions · 2022-05-05T18:38:43Z

PR tests (clang-14, ubuntu, mpich)

Build for 54bd0fd

In file included from src/CMakeFiles/vt.dir/Unity/unity_14_cxx.cxx:7:
/vt/src/vt/utils/memory/memory_usage.cc:149:26: warning: 'mallinfo' is deprecated [-Wdeprecated-declarations]
    struct mallinfo mi = mallinfo();
                         ^
/usr/include/malloc.h:114:48: note: 'mallinfo' has been explicitly marked deprecated here
extern struct mallinfo mallinfo (void) __THROW __MALLOC_DEPRECATED;
                                               ^
/usr/include/malloc.h:32:30: note: expanded from macro '__MALLOC_DEPRECATED'
# define __MALLOC_DEPRECATED __attribute_deprecated__
                             ^
/usr/include/x86_64-linux-gnu/sys/cdefs.h:339:51: note: expanded from macro '__attribute_deprecated__'
# define __attribute_deprecated__ __attribute__ ((__deprecated__))
                                                  ^
1 warning generated.

Testing - passed

Build log

cz4rs · 2022-05-06T12:32:07Z

cmake-modules/SetCXXCompilerFlags.cmake

-
-macro(set_darma_compiler_flags vt_target)
-
-set(CMAKE_CXX_EXTENSIONS OFF)


removed: CMAKE_CXX_EXTENSIONS is already disabled in the main CMakeLists.txt

cz4rs · 2022-05-06T12:32:51Z

cmake-modules/SetCXXCompilerFlags.cmake

  endif ()
-  if (CMAKE_CXX_COMPILER_VERSION VERSION_GREATER_EQUAL 7)
-    list(APPEND TARGET_PUBLIC_CXX_FLAGS -DCLI11_EXPERIMENTAL_OPTIONAL=0)


removed: CLI11_EXPERIMENTAL_OPTIONAL is no longer present in CLI11

PhilMiller · 2022-05-06T17:51:46Z

I think this is good, but I want to take another look, or have someone else look at it too.

cz4rs · 2022-05-09T08:45:51Z

Rebased on top of develop.

codecov · 2022-05-09T19:25:46Z

Codecov Report

Merging #1776 (54bd0fd) into develop (5423e23) will not change coverage.
The diff coverage is n/a.

@@           Coverage Diff            @@
##           develop    #1776   +/-   ##
========================================
  Coverage    84.14%   84.14%           
========================================
  Files          753      753           
  Lines        26127    26127           
========================================
  Hits         21985    21985           
  Misses        4142     4142

Increase required CMake version to avoid planned deprecation warnings.

cz4rs force-pushed the 1765-common-compilation-flags branch from 29b44af to 92be9dd Compare May 5, 2022 18:08

cz4rs force-pushed the 1765-common-compilation-flags branch 2 times, most recently from 26cca2b to dac21a9 Compare May 5, 2022 20:58

cz4rs commented May 6, 2022

View reviewed changes

cz4rs force-pushed the 1765-common-compilation-flags branch 2 times, most recently from a04e9a5 to e7a7f74 Compare May 6, 2022 13:06

cz4rs marked this pull request as ready for review May 6, 2022 15:09

cz4rs requested review from jstrzebonski and lifflander May 6, 2022 15:09

cz4rs requested review from nmm0, JacobDomagala, nlslatt and PhilMiller May 6, 2022 15:09

cz4rs force-pushed the 1765-common-compilation-flags branch from e7a7f74 to e0b8fae Compare May 9, 2022 07:21

cz4rs force-pushed the 1765-common-compilation-flags branch from e0b8fae to ea9bb8e Compare May 9, 2022 19:15

cz4rs force-pushed the 1765-common-compilation-flags branch from ea9bb8e to 078861a Compare May 10, 2022 12:29

lifflander mentioned this pull request May 10, 2022

Meeting Agenda [do not close] #925

Open

cz4rs added 10 commits May 13, 2022 12:32

#1765: use vt compilation flags for bundled libraries

bb3b323

#1765: remove obsolete CLI11 flag

08ecf95

#1765: do not set compilation flags for header-only libraries

eb2ee29

#1765: only enable sanitizers for vt target

6a9bcd6

#1765: CMake: remove obsolete code

25348a1

#1765: CMake: set diagnostic related flags from single file

8164b4d

#1765: CMake: make set_darma_compiler_flags a function

48b4117

#1765: CMake: avoid redundant variables

f103b7b

#1765: CMake: set compilation flags when loading libraries

cbca813

#1765: bump required CMake version in bundled libraries

54bd0fd

Increase required CMake version to avoid planned deprecation warnings.

cz4rs force-pushed the 1765-common-compilation-flags branch from 078861a to 54bd0fd Compare May 13, 2022 10:32

PhilMiller approved these changes May 16, 2022

View reviewed changes

PhilMiller merged commit ce6b977 into develop May 16, 2022

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

1765: use vt compilation flags for bundled libraries as well #1776

1765: use vt compilation flags for bundled libraries as well #1776

cz4rs commented May 5, 2022

github-actions bot commented May 5, 2022 •

edited

Loading

github-actions bot commented May 5, 2022 •

edited

Loading

github-actions bot commented May 5, 2022 •

edited

Loading

github-actions bot commented May 5, 2022 •

edited

Loading

github-actions bot commented May 5, 2022 •

edited

Loading

github-actions bot commented May 5, 2022 •

edited

Loading

github-actions bot commented May 5, 2022 •

edited

Loading

github-actions bot commented May 5, 2022 •

edited

Loading

github-actions bot commented May 5, 2022 •

edited

Loading

github-actions bot commented May 5, 2022 •

edited

Loading

github-actions bot commented May 5, 2022 •

edited

Loading

github-actions bot commented May 5, 2022 •

edited

Loading

github-actions bot commented May 5, 2022 •

edited

Loading

github-actions bot commented May 5, 2022 •

edited

Loading

github-actions bot commented May 5, 2022 •

edited

Loading

github-actions bot commented May 5, 2022 •

edited

Loading

github-actions bot commented May 5, 2022 •

edited

Loading

github-actions bot commented May 5, 2022 •

edited

Loading

github-actions bot commented May 5, 2022 •

edited

Loading

github-actions bot commented May 5, 2022 •

edited

Loading

cz4rs May 6, 2022 •

edited

Loading

cz4rs May 6, 2022 •

edited

Loading

PhilMiller commented May 6, 2022

cz4rs commented May 9, 2022

codecov bot commented May 9, 2022 •

edited

Loading


		macro(set_darma_compiler_flags vt_target)

		set(CMAKE_CXX_EXTENSIONS OFF)

1765: use vt compilation flags for bundled libraries as well #1776

1765: use vt compilation flags for bundled libraries as well #1776

Conversation

cz4rs commented May 5, 2022

github-actions bot commented May 5, 2022 • edited Loading

github-actions bot commented May 5, 2022 • edited Loading

github-actions bot commented May 5, 2022 • edited Loading

github-actions bot commented May 5, 2022 • edited Loading

github-actions bot commented May 5, 2022 • edited Loading

github-actions bot commented May 5, 2022 • edited Loading

github-actions bot commented May 5, 2022 • edited Loading

github-actions bot commented May 5, 2022 • edited Loading

github-actions bot commented May 5, 2022 • edited Loading

github-actions bot commented May 5, 2022 • edited Loading

github-actions bot commented May 5, 2022 • edited Loading

github-actions bot commented May 5, 2022 • edited Loading

github-actions bot commented May 5, 2022 • edited Loading

github-actions bot commented May 5, 2022 • edited Loading

github-actions bot commented May 5, 2022 • edited Loading

github-actions bot commented May 5, 2022 • edited Loading

github-actions bot commented May 5, 2022 • edited Loading

github-actions bot commented May 5, 2022 • edited Loading

github-actions bot commented May 5, 2022 • edited Loading

github-actions bot commented May 5, 2022 • edited Loading

cz4rs May 6, 2022 • edited Loading

Choose a reason for hiding this comment

cz4rs May 6, 2022 • edited Loading

Choose a reason for hiding this comment

PhilMiller commented May 6, 2022

cz4rs commented May 9, 2022

codecov bot commented May 9, 2022 • edited Loading

Codecov Report

github-actions bot commented May 5, 2022 •

edited

Loading

github-actions bot commented May 5, 2022 •

edited

Loading

github-actions bot commented May 5, 2022 •

edited

Loading

github-actions bot commented May 5, 2022 •

edited

Loading

github-actions bot commented May 5, 2022 •

edited

Loading

github-actions bot commented May 5, 2022 •

edited

Loading

github-actions bot commented May 5, 2022 •

edited

Loading

github-actions bot commented May 5, 2022 •

edited

Loading

github-actions bot commented May 5, 2022 •

edited

Loading

github-actions bot commented May 5, 2022 •

edited

Loading

github-actions bot commented May 5, 2022 •

edited

Loading

github-actions bot commented May 5, 2022 •

edited

Loading

github-actions bot commented May 5, 2022 •

edited

Loading

github-actions bot commented May 5, 2022 •

edited

Loading

github-actions bot commented May 5, 2022 •

edited

Loading

github-actions bot commented May 5, 2022 •

edited

Loading

github-actions bot commented May 5, 2022 •

edited

Loading

github-actions bot commented May 5, 2022 •

edited

Loading

github-actions bot commented May 5, 2022 •

edited

Loading

github-actions bot commented May 5, 2022 •

edited

Loading

cz4rs May 6, 2022 •

edited

Loading

cz4rs May 6, 2022 •

edited

Loading

codecov bot commented May 9, 2022 •

edited

Loading