Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

use vt compilation flags for bundled libraries as well #1765

Closed
cz4rs opened this issue May 4, 2022 · 0 comments · Fixed by #1776
Closed

use vt compilation flags for bundled libraries as well #1765

cz4rs opened this issue May 4, 2022 · 0 comments · Fixed by #1776
Assignees

Comments

@cz4rs
Copy link
Contributor

cz4rs commented May 4, 2022

Describe the bug
icpx build is showing following warnings:

/vt/lib/EngFormat-Cpp/src/eng_format.cpp:144:15: warning: comparison with NaN always evaluates to false in fast floating point modes [-Wtautological-constant-compare]
    if      ( std::isnan( value ) ) return "NaN";
              ^~~~~~~~~~~~~~~~~~~
/vt/lib/EngFormat-Cpp/src/eng_format.cpp:145:15: warning: comparison with infinity always evaluates to false in fast floating point modes [-Wtautological-constant-compare]
    else if ( std::isinf( value ) ) return "INFINITE";
              ^~~~~~~~~~~~~~~~~~~
2 warnings generated.

This is because we only set the project's common compiler flags to vt target:

$ git grep set_darma_compiler_flags
cmake-modules/SetCXXCompilerFlags.cmake:3:macro(set_darma_compiler_flags vt_target)
src/CMakeLists.txt:243:set_darma_compiler_flags(${VIRTUAL_TRANSPORT_LIBRARY})

Expected behavior
Use the same (or as similar as possible) set of flags for bundled libraries as for vt.

@cz4rs cz4rs added the type: bug label May 4, 2022
@cz4rs cz4rs self-assigned this May 4, 2022
cz4rs added a commit that referenced this issue May 5, 2022
cz4rs added a commit that referenced this issue May 5, 2022
cz4rs added a commit that referenced this issue May 5, 2022
cz4rs added a commit that referenced this issue May 5, 2022
cz4rs added a commit that referenced this issue May 5, 2022
cz4rs added a commit that referenced this issue May 6, 2022
cz4rs added a commit that referenced this issue May 6, 2022
cz4rs added a commit that referenced this issue May 6, 2022
cz4rs added a commit that referenced this issue May 9, 2022
cz4rs added a commit that referenced this issue May 9, 2022
cz4rs added a commit that referenced this issue May 9, 2022
cz4rs added a commit that referenced this issue May 9, 2022
cz4rs added a commit that referenced this issue May 10, 2022
cz4rs added a commit that referenced this issue May 10, 2022
cz4rs added a commit that referenced this issue May 10, 2022
cz4rs added a commit that referenced this issue May 13, 2022
cz4rs added a commit that referenced this issue May 13, 2022
cz4rs added a commit that referenced this issue May 13, 2022
cz4rs added a commit that referenced this issue May 13, 2022
Increase required CMake version to avoid planned deprecation warnings.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant