Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

move getModeledWork out of TemeperedWMin #1838

Closed
cz4rs opened this issue Jun 1, 2022 · 1 comment · Fixed by #1888
Closed

move getModeledWork out of TemeperedWMin #1838

cz4rs opened this issue Jun 1, 2022 · 1 comment · Fixed by #1888
Assignees
Labels

Comments

@cz4rs
Copy link
Contributor

cz4rs commented Jun 1, 2022

Having getModeledWork baked into load balancer makes it impossible to compute post-LB statistics. This could possibly be moved into a new load model, but we have to find a way to pass parameters into it (alpha, beta, gamma).
A more general solutions for load models might be required.


Should this be implemented as a new load model instead of integrated into the load balancer? Load models can be composed, so you'd still be able to plug in whatever model you wanted for the loads.

Having the formula integrated into the LB makes it impossible for vt to compute post-LB statistics following the formula. What we dump to the LB statistics json file post-LB would be incorrect but I'm not sure if it would have any other immediate consequences. I think it might break the (not yet implemented) capability to run multiple load balancers and use the most effective result.

What do you think, @PhilMiller and @ppebay?

Originally posted by @nlslatt in #1695 (comment)

@cz4rs
Copy link
Contributor Author

cz4rs commented Jul 27, 2022

As discussed on LB meeting:

  • implement WeightedCommunicationVolume load model that takes alpha, beta, gamma as ctor arguments

Possibly in another issue: move into #1884

  • add labels to load models (including suitable mechanism for composed models!)
  • include the labels in post-LB JSON output

cz4rs added a commit that referenced this issue Aug 4, 2022
Add `getModeledWork` to `ComposedModel` class. Return object's load as
modeled work when there is no implementation in derived classes.
cz4rs added a commit that referenced this issue Aug 4, 2022
Add `getModeledWork` to `ComposedModel` class. Return object's load as
modeled work when there is no implementation in derived classes.
cz4rs added a commit that referenced this issue Sep 30, 2022
cz4rs added a commit that referenced this issue Sep 30, 2022
cz4rs added a commit that referenced this issue Oct 3, 2022
cz4rs added a commit that referenced this issue Nov 8, 2022
cz4rs added a commit that referenced this issue Nov 8, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant