#1838: TemperedWMin: make sure that load model does not change

DARMA-tasking · Aug 9, 2022 · 3441b9e · 3441b9e
1 parent 67a1d2d
commit 3441b9e
Show file tree

Hide file tree

Showing 2 changed files with 7 additions and 0 deletions.
diff --git a/src/vt/vrt/collection/balance/temperedwmin/temperedwmin.cc b/src/vt/vrt/collection/balance/temperedwmin/temperedwmin.cc
@@ -43,6 +43,7 @@
 
 #include "vt/vrt/collection/balance/temperedwmin/temperedwmin.h"
 
+#include "vt/configs/error/config_assert.h"
 #include "vt/vrt/collection/balance/lb_invoke/lb_manager.h"
 #include "vt/vrt/collection/balance/model/load_model.h"
 #include "vt/vrt/collection/balance/model/weighted_communication_volume.h"
@@ -99,9 +100,14 @@ void TemperedWMin::inputParams(balance::SpecEntry* spec) {
   total_work_model_ = std::make_unique<balance::WeightedCommunicationVolume>(
     theLBManager()->getLoadModel(), alpha_, beta_, gamma_
   );
+  load_model_ptr = theLBManager()->getLoadModel().get();
 }
 
 TimeType TemperedWMin::getModeledValue(const elm::ElementIDStruct& obj) {
+  vtAssert(
+    theLBManager()->getLoadModel().get() == load_model_ptr,
+    "Load model must not change"
+  );
   balance::PhaseOffset when =
       {balance::PhaseOffset::NEXT_PHASE, balance::PhaseOffset::WHOLE_PHASE};
 

diff --git a/src/vt/vrt/collection/balance/temperedwmin/temperedwmin.h b/src/vt/vrt/collection/balance/temperedwmin/temperedwmin.h
@@ -68,6 +68,7 @@ struct TemperedWMin : TemperedLB {
 
 private:
   std::unique_ptr<balance::LoadModel> total_work_model_ = nullptr;
+  balance::LoadModel* load_model_ptr = nullptr;
 
   double alpha_ = 1.0;
   double beta_  = 0.0;