-
-
Notifications
You must be signed in to change notification settings - Fork 43
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add support for metadata component #118
Conversation
Thanks for the PR @artem-smotrakov. We're in the process of a notable update at present to support the forthcoming CycloneDX 1.4 schema - so please forgive us if we wait for that work to stabilise before we look at merging your PR. Cheers! |
enabled CI to run CT/QA. in the meantime: could you check that all tests pass, @artem-smotrakov ? |
Hmm, I read the contributing guidelines and ran tests and |
d408d01
to
2d3dece
Compare
I've fixed several formatting and typing issues. |
Hi @artem-smotrakov - we've just merged changes for CycloneDX 1.4 - are you willing to rebase this branch from main? Thanks, Paul |
5b9f94b
to
623ac38
Compare
@madpah I've rebased it -- please rerun CI/CD and have a look at the updates. I am not sure about this one: I've noticed that if a BOM doesn't have components, |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@artem-smotrakov - thanks again for the PR.
It's interesting you have pointed out that components
is output as an empty element in some cases - ideally this should not be output if there are no Components - but we are happy to resolve this as a separate bug later.
c312e85
to
a396578
Compare
@madpah I've addressed your comments -- thanks for the review! |
9f71e27
to
551813f
Compare
Part of CycloneDX#6 Signed-off-by: Artem Smotrakov <asmotrakov@riotgames.com>
Signed-off-by: Artem Smotrakov <asmotrakov@riotgames.com>
551813f
to
77f65fc
Compare
Part of #6