Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[FEATURE] More complete support for bom.metadata #6

Closed
madpah opened this issue Sep 16, 2021 · 4 comments · Fixed by #148
Closed

[FEATURE] More complete support for bom.metadata #6

madpah opened this issue Sep 16, 2021 · 4 comments · Fixed by #148
Assignees
@madpah @artem-smotrakov
Labels
enhancement New feature or request schema 1.2 schema 1.3 schema 1.4
Milestone
2.0.0

Comments

@madpah
Copy link
Collaborator

madpah commented Sep 16, 2021

This issue was originally raised here but has been relocated to this project as it is now the cyclonedx-python-lib that implements the specification and not cyclonedx-python.

References from original issue:

Notes from @stevespringett:

  • authors is intended for human creators of the SBOM. This tool produces them through automation, so I'd recommend having support for the metadata\component and metadata\tools\tool

Notes from @sbs2001:
@madpah madpah added the enhancement New feature or request label Sep 16, 2021
@madpah madpah self-assigned this Sep 16, 2021
@madpah madpah mentioned this issue Sep 16, 2021
Closed
@madpah
Copy link
Collaborator Author

madpah commented Sep 16, 2021

Issue CycloneDX/cyclonedx-python#122 also specifically makes request for support of:

  • bom.metadata.authors
  • bom.metadata.manufacture
  • bom.metadata.supplier

The current version of cyclonedx-python-lib has regressed some support for bom.metadata.authors (see CycloneDX/cyclonedx-python#125).

@madpah madpah mentioned this issue Sep 16, 2021
Closed
@madpah madpah removed their assignment Sep 16, 2021
@madpah
Copy link
Collaborator Author

madpah commented Oct 14, 2021

bom.metadata.tools is now supported.

artem-smotrakov added a commit to artem-smotrakov/cyclonedx-python-lib that referenced this issue Jan 4, 2022
@artem-smotrakov
Add support for metadata component
63b5754 
This is part of CycloneDX#6
artem-smotrakov added a commit to artem-smotrakov/cyclonedx-python-lib that referenced this issue Jan 4, 2022
@artem-smotrakov
Add support for metadata component
d408d01 
Part of CycloneDX#6

Signed-off-by: Artem Smotrakov <asmotrakov@riotgames.com>
@artem-smotrakov artem-smotrakov mentioned this issue Jan 4, 2022
Merged
@artem-smotrakov
Copy link
Contributor

I guess #118 should close this issue.

@madpah
Copy link
Collaborator Author

madpah commented Jan 4, 2022

Thanks for the PR @artem-smotrakov. We're in the process of a notable update at present to support the forthcoming CycloneDX 1.4 schema - so please forgive us if we wait for that work to stabilise before we look at merging your PR.

Cheers!

@madpah madpah mentioned this issue Jan 4, 2022
Closed
artem-smotrakov added a commit to artem-smotrakov/cyclonedx-python-lib that referenced this issue Jan 4, 2022
@artem-smotrakov
Add support for metadata component
2d3dece 
Part of CycloneDX#6

Signed-off-by: Artem Smotrakov <asmotrakov@riotgames.com>
@madpah madpah changed the title FEATURE: More complete support for bom.metadata (schema version 1.2+) [FEATURE] More complete support for bom.metadata Jan 6, 2022
artem-smotrakov added a commit to artem-smotrakov/cyclonedx-python-lib that referenced this issue Jan 13, 2022
@artem-smotrakov
Add support for metadata component
5b9f94b 
Part of CycloneDX#6

Signed-off-by: Artem Smotrakov <artem.smotrakov@gmail.com>
artem-smotrakov added a commit to artem-smotrakov/cyclonedx-python-lib that referenced this issue Jan 13, 2022
@artem-smotrakov
Add support for metadata component
623ac38 
Part of CycloneDX#6

Signed-off-by: Artem Smotrakov <artem.smotrakov@gmail.com>
@madpah madpah assigned madpah and artem-smotrakov and unassigned madpah Jan 13, 2022
@madpah madpah linked a pull request Jan 13, 2022 that will close this issue
Add support for metadata component #118
Merged
artem-smotrakov added a commit to artem-smotrakov/cyclonedx-python-lib that referenced this issue Jan 13, 2022
@artem-smotrakov
Add support for metadata component
3011fb0 
Part of CycloneDX#6

Signed-off-by: Artem Smotrakov <asmotrakov@riotgames.com>
artem-smotrakov added a commit to artem-smotrakov/cyclonedx-python-lib that referenced this issue Jan 13, 2022
@artem-smotrakov
Add support for metadata component
7a184ce 
Part of CycloneDX#6

Signed-off-by: Artem Smotrakov <asmotrakov@riotgames.com>
artem-smotrakov added a commit to artem-smotrakov/cyclonedx-python-lib that referenced this issue Jan 13, 2022
@artem-smotrakov
Add support for metadata component
72cb7dd 
Part of CycloneDX#6

Signed-off-by: Artem Smotrakov <asmotrakov@riotgames.com>
@madpah madpah removed a link to a pull request Jan 13, 2022
Add support for metadata component #118
Merged
madpah pushed a commit that referenced this issue Jan 13, 2022
@artem-smotrakov
feat: add support for bom.metadata.component (#118)
1ac31f4 
* Add support for metadata component

Part of #6

Signed-off-by: Artem Smotrakov <asmotrakov@riotgames.com>

* Better docs and simpler ifs

Signed-off-by: Artem Smotrakov <asmotrakov@riotgames.com>
@madpah madpah mentioned this issue Feb 8, 2022
Merged
@madpah madpah mentioned this issue Feb 8, 2022
Merged
@madpah madpah linked a pull request Feb 8, 2022 that will close this issue
RELEASE 2.0.0 #148
Merged
@madpah madpah added this to the 2.0.0 milestone Feb 8, 2022
@madpah madpah self-assigned this Feb 8, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@madpah madpah

@artem-smotrakov artem-smotrakov

Labels
enhancement New feature or request schema 1.2 schema 1.3 schema 1.4
Projects
None yet
Milestone
2.0.0
Development

Successfully merging a pull request may close this issue.

RELEASE 2.0.0 CycloneDX/cyclonedx-python-lib
3 participants
@jkowalleck @madpah @artem-smotrakov