Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Include component.author node in generated SBOM #246

Closed
shiraze opened this issue Jan 26, 2022 · 1 comment · Fixed by #247
Closed

Include component.author node in generated SBOM #246

shiraze opened this issue Jan 26, 2022 · 1 comment · Fixed by #247

Comments

@shiraze
Copy link

shiraze commented Jan 26, 2022

I noticed that the author node from the package.json file isn't included in the generated SBOM. I would expect this value to be copied to the SBOM metadata.component.author node.

@jkowalleck
Copy link
Member

thaks for the hint, @shiraze
could you review #247?

jkowalleck added a commit that referenced this issue Jan 26, 2022
fixes #246

Signed-off-by: Jan Kowalleck <jan.kowalleck@gmail.com>
@jkowalleck jkowalleck changed the title Include author node in generated SBOM Include component.author node in generated SBOM Jan 28, 2022
jkowalleck added a commit that referenced this issue Jan 28, 2022
fixes #246
fixes #248
part of #233
part of #220

Signed-off-by: Jan Kowalleck <jan.kowalleck@gmail.com>
jkowalleck added a commit that referenced this issue Jan 28, 2022
fixes #246
fixes #248
part of #233
part of #220

Signed-off-by: Jan Kowalleck <jan.kowalleck@gmail.com>
jkowalleck added a commit that referenced this issue Jan 28, 2022
detect component.author - fixes #246
normalize empty component.version - fixes #248
add JSDoc - #220
use private properties - #233

Signed-off-by: Jan Kowalleck <jan.kowalleck@gmail.com>
jkowalleck added a commit that referenced this issue Jan 29, 2022
detect component.author - fixes #246
normalize empty component.version - fixes #248
add JSDoc - #220
use private properties - #233

Signed-off-by: Jan Kowalleck <jan.kowalleck@gmail.com>
jkowalleck added a commit that referenced this issue Feb 2, 2022
…ormalize optional `version` (#247)

* Changed
  * Private/protected properties of Component models are no longer directly accessible. ([#233] via [#247])  
    Access via public getter/setter.
* Fixed
  * Normalization guarantees `component.version`. ([#248] via [#247])
  * Component's constructor may detect & set `autor` based on package info. ([#246] via [#247])
* Added
  * JSDoc for Component model. ([#220] via [#247])

[#220]: #220
[#233]: #233
[#246]: #246
[#247]: #247
[#248]: #248

---

* Component rework

detect component.author - fixes #246
normalize empty component.version - fixes #248
add JSDoc - #220
use private properties - #233

Signed-off-by: Jan Kowalleck <jan.kowalleck@gmail.com>

* use `@babel/eslint-parser`

Signed-off-by: Jan Kowalleck <jan.kowalleck@gmail.com>

* update locked dependencies and lockfile format

Signed-off-by: Jan Kowalleck <jan.kowalleck@gmail.com>

* CT/CI generates jsdoc & play with jsdoc

Signed-off-by: Jan Kowalleck <jan.kowalleck@gmail.com>

* wrote history

Signed-off-by: Jan Kowalleck <jan.kowalleck@gmail.com>

* slacked components getterusage internally

Signed-off-by: Jan Kowalleck <jan.kowalleck@gmail.com>

* fixed JSDoc `object` annotation

Signed-off-by: Jan Kowalleck <jan.kowalleck@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
2 participants