use private properties with #
#233
Comments
jkowalleck
added a commit
that referenced
this issue
Jan 27, 2022
jkowalleck
added a commit
that referenced
this issue
Jan 28, 2022
jkowalleck
added a commit
that referenced
this issue
Jan 28, 2022
jkowalleck
added a commit
that referenced
this issue
Jan 28, 2022
jkowalleck
added a commit
that referenced
this issue
Jan 29, 2022
jkowalleck
added a commit
that referenced
this issue
Feb 2, 2022
…ormalize optional `version` (#247) * Changed * Private/protected properties of Component models are no longer directly accessible. ([#233] via [#247]) Access via public getter/setter. * Fixed * Normalization guarantees `component.version`. ([#248] via [#247]) * Component's constructor may detect & set `autor` based on package info. ([#246] via [#247]) * Added * JSDoc for Component model. ([#220] via [#247]) [#220]: #220 [#233]: #233 [#246]: #246 [#247]: #247 [#248]: #248 --- * Component rework detect component.author - fixes #246 normalize empty component.version - fixes #248 add JSDoc - #220 use private properties - #233 Signed-off-by: Jan Kowalleck <jan.kowalleck@gmail.com> * use `@babel/eslint-parser` Signed-off-by: Jan Kowalleck <jan.kowalleck@gmail.com> * update locked dependencies and lockfile format Signed-off-by: Jan Kowalleck <jan.kowalleck@gmail.com> * CT/CI generates jsdoc & play with jsdoc Signed-off-by: Jan Kowalleck <jan.kowalleck@gmail.com> * wrote history Signed-off-by: Jan Kowalleck <jan.kowalleck@gmail.com> * slacked components getterusage internally Signed-off-by: Jan Kowalleck <jan.kowalleck@gmail.com> * fixed JSDoc `object` annotation Signed-off-by: Jan Kowalleck <jan.kowalleck@gmail.com>
jkowalleck
added a commit
that referenced
this issue
Apr 24, 2022
* Added
* Environment variable `BOM_REPRODUCIBLE` cause resulting files to be more reproducible
by omitting time/rand-based values, and sorting lists. (via [#288])
* Method `Component.compare()` compares self by `purl` or `group`/`name`/`version`. (via [#288])
* Method `ExternalReference.compare()` compares self by `type`/`url`. (via [#288])
* Method `Hash.compare()` compares self by `algorithm`/`value`. (via [#288])
* JSDoc for `ExternalReference`, `ExternalReferenceList`, `Hash`, `HashList`. (via [#288])
* Fixed
* `ExternalReference.url` is now correctly treated as mandatory. (via [#288])
* `Hash.value` is now correctly treated as mandatory. (via [#288])
* `ExternalReferenceList.isEligibleHomepage` now returns the correct result, was inverted. (via [#288])
* Changed
* Private properties of `ExternalReference`, `ExternalReferenceList`, `Hash`, `HashList`
became inaccessible. ([#233] via [#288])
[#288]: #288
[#233]: #233
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
since node12/es6 classes may have private properties - starting with
#see https://developer.mozilla.org/en-US/docs/Web/JavaScript/Reference/Classes/Private_class_fields
currently
_is used to mark properties as internal.goal: use
#this is considered a non-breaking "style" change, because the current privates were never intended to be used downstream.
If this breaks something for a user downstream, then they ran the code on their own risks already.
The text was updated successfully, but these errors were encountered: