Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Cleanup code with modules #26

Closed
4 tasks done
CubBossa opened this issue Mar 1, 2023 · 0 comments
Closed
4 tasks done

Cleanup code with modules #26

CubBossa opened this issue Mar 1, 2023 · 0 comments
Assignees
@CubBossa
Labels
enhancement New feature or request
Milestone
v3.0.0

Comments

@CubBossa
Copy link
Owner

CubBossa commented Mar 1, 2023 •
edited
Loading

Split the code into modules with their according dependencies. E.g.: Move the editmode visualizer into a different module, as its the only thing that requires ProtocolLib. If someone wants to use pathfinder for minigames as a library it is not required to use the editmode, therefore ProtocolLib and e.g. MenuFramework are not required. They can shade the modules that they need.

  • graph module (required by core)
  • editmode module (optional for core?)
  • javascript visualizer module (optional for core)

--- Edit
Splitting the main module into plugin and api/core will not happen in v3.0.0, maybe this comes with the major changes in v4.0.0. Meanwhile the main module serves as coding dependency

  • reduce jar size (currently massive due to gradle shading)
@CubBossa CubBossa added the enhancement New feature or request label Mar 1, 2023
@CubBossa CubBossa self-assigned this Mar 1, 2023
CubBossa added a commit that referenced this issue Mar 1, 2023
@CubBossa
#26 modules
cf4360a 
graph module separated
@CubBossa CubBossa added this to the v3.0.0 milestone Mar 1, 2023
LooFifteen added a commit to LooFifteen/PathFinder that referenced this issue Mar 1, 2023
@LooFifteen @CubBossa
refactor!: split project into modules
6033baa 
* closes CubBossa#19 edge concurrency problems

* closes CubBossa#24

* Close CubBossa#22

* Closes CubBossa#21

* compass visualizer default interval of 1 instead of 20

* Version increment

* CubBossa#26 modules

graph module separated

* fix: use Java 17 for all modules

---------

Co-authored-by: CubBossa <leonard.bausenwein@web.de>
CubBossa added a commit that referenced this issue Mar 1, 2023
@CubBossa
#26 modules: moved dependencies into fitting submodules
a5e47cf
LooFifteen added a commit to LooFifteen/PathFinder that referenced this issue Mar 1, 2023
@LooFifteen
Merge remote-tracking branch 'upstream/feature/CubBossa#26-modules' i…
7af879b 
…nto refactor/gradle-modules

# Conflicts:
#	PathFinder-core/pom.xml
#	PathFinder-graph/pom.xml
#	pom.xml
CubBossa added a commit that referenced this issue Mar 2, 2023
@CubBossa
#26 fixes and serviceloader tests
a383453
CubBossa added a commit that referenced this issue Mar 2, 2023
@CubBossa
#26 abstract edit mode
d03c2d1
@CubBossa CubBossa mentioned this issue Mar 2, 2023
Closed
CubBossa added a commit that referenced this issue Mar 2, 2023
@CubBossa
#26 Make PathPluginExtension a loadable service
afb9e18
CubBossa added a commit that referenced this issue Mar 7, 2023
@CubBossa
#26 module for javascript dependency
529c58c
CubBossa added a commit that referenced this issue Mar 9, 2023
@CubBossa
#26 reduce jar size
73d8f2f
CubBossa added a commit that referenced this issue Mar 10, 2023
@CubBossa
#26 project structure in README, shrink jar
72cdf54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@CubBossa CubBossa

Labels
enhancement New feature or request
Projects
None yet
Milestone
v3.0.0
Development

No branches or pull requests
1 participant
@CubBossa