Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

ConcurrentModificationException when deleting edges while connecting #19

Closed
CubBossa opened this issue Feb 24, 2023 · 1 comment
Closed

ConcurrentModificationException when deleting edges while connecting #19

CubBossa opened this issue Feb 24, 2023 · 1 comment
Labels
bug Something isn't working

Comments

@CubBossa
Copy link
Owner

When using the roadmap editor, disconnecting nodes will cause a ConcurrentModificationException if the edge tool has its first node set.

java.util.ConcurrentModificationException: null
        at java.util.ArrayList.forEach(ArrayList.java:1513) ~[?:?]
        at de.cubbossa.pathfinder.core.roadmap.RoadMap.disconnectNode(RoadMap.java:434) ~[PathFinder-2.1.0.jar:?]
        at de.cubbossa.pathfinder.core.menu.EditModeMenu.lambda$createHotbarMenu$9(EditModeMenu.java:141) ~[PathFinder-2.1.0.jar:?]
        at de.cubbossa.pathfinder.gui.inventory.AbstractMenu.handleInteract(AbstractMenu.java:368) ~[PathFinder-2.1.0.jar:?]
        at de.cubbossa.pathfinder.util.ClientNodeHandler$2.onPacketReceiving(ClientNodeHandler.java:146) ~[PathFinder-2.1.0.jar:?]
        at com.comphenix.protocol.injector.SortedPacketListenerList.invokeReceivingListener(SortedPacketListenerList.java:114) ~[ProtocolLib.jar:?]
        at com.comphenix.protocol.injector.SortedPacketListenerList.invokePacketRecieving(SortedPacketListenerList.java:67) ~[ProtocolLib.jar:?]
        at com.comphenix.protocol.injector.PacketFilterManager.postPacketToListeners(PacketFilterManager.java:549) ~[ProtocolLib.jar:?]
        at com.comphenix.protocol.injector.PacketFilterManager.invokePacketReceiving(PacketFilterManager.java:514) ~[ProtocolLib.jar:?]
        at com.comphenix.protocol.injector.netty.manager.NetworkManagerInjector.onPacketReceiving(NetworkManagerInjector.java:117) ~[ProtocolLib.jar:?]
        at com.comphenix.protocol.injector.netty.channel.NettyChannelInjector.processInboundPacket(NettyChannelInjector.java:505) ~[ProtocolLib.jar:?]
        at com.comphenix.protocol.injector.netty.channel.InboundPacketInterceptor.channelRead(InboundPacketInterceptor.java:33) ~[ProtocolLib.jar:?]
@CubBossa CubBossa added the bug Something isn't working label Feb 24, 2023
@CubBossa
Copy link
Owner Author

Actually happens whenever a node is being leftclicked = disconnect all

CubBossa added a commit that referenced this issue Feb 27, 2023
@CubBossa
closes #19 edge concurrency problems
60fcbfd
LooFifteen added a commit to LooFifteen/PathFinder that referenced this issue Mar 1, 2023
@LooFifteen @CubBossa
refactor!: split project into modules
6033baa 
* closes CubBossa#19 edge concurrency problems

* closes CubBossa#24

* Close CubBossa#22

* Closes CubBossa#21

* compass visualizer default interval of 1 instead of 20

* Version increment

* CubBossa#26 modules

graph module separated

* fix: use Java 17 for all modules

---------

Co-authored-by: CubBossa <leonard.bausenwein@web.de>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug Something isn't working
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@CubBossa