Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove Long Deprecated SmartSim Modules #514

Merged
merged 6 commits into from
Mar 14, 2024
Merged

Remove Long Deprecated SmartSim Modules #514

Show file tree
Hide file tree
Changes from 4 commits
Commits
Show all changes
6 commits
Select commit Hold shift + click to select a range
22182c9
depricate initial push
amandarichardsonn Mar 11, 2024
c8f7a09
small doc format
amandarichardsonn Mar 11, 2024
9dfd3c8
make black
amandarichardsonn Mar 12, 2024
bd07742
Merge branch 'develop' of https://www.github.com/CrayLabs/SmartSim in…
amandarichardsonn Mar 13, 2024
d82269d
edit to changelog
amandarichardsonn Mar 13, 2024
eb20468
small edit to changelog
amandarichardsonn Mar 13, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
12 changes: 9 additions & 3 deletions doc/api/smartsim_api.rst
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -538,12 +538,18 @@ SmartSim includes built-in utilities for supporting PyTorch in training and infe
Slurm
=====

.. currentmodule:: smartsim.slurm
.. currentmodule:: smartsim.wlm.slurm

.. autosummary::

get_allocation
release_allocation

.. automodule:: smartsim.slurm
validate
get_default_partition
get_hosts
get_queue
get_tasks
get_tasks_per_node

.. automodule:: smartsim.wlm.slurm
:members:
41 changes: 0 additions & 41 deletions smartsim/settings/mpirunSettings.py
View file
Open in desktop

This file was deleted.

45 changes: 0 additions & 45 deletions smartsim/slurm.py
View file
Open in desktop

This file was deleted.

4 changes: 2 additions & 2 deletions smartsim/wlm/slurm.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -60,12 +60,12 @@ def get_allocation(
The options can be used to pass extra settings to the
workload manager such as the following for Slurm:

- nodelist="nid00004"
- nodelist="nid00004"

For arguments without a value, pass None or and empty
string as the value. For Slurm:

- exclusive=None
- exclusive=None

:param nodes: number of nodes for the allocation, defaults to 1
:type nodes: int, optional
Expand Down
2 changes: 1 addition & 1 deletion tests/test_slurm_get_alloc.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -26,7 +26,7 @@

import pytest

from smartsim.slurm import _get_alloc_cmd
from smartsim.wlm.slurm import _get_alloc_cmd

# The tests in this file belong to the group_b group
pytestmark = pytest.mark.group_b
Expand Down
6 changes: 5 additions & 1 deletion tests/test_slurm_validation.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -28,7 +28,11 @@
import pytest

from smartsim.error.errors import LauncherError
from smartsim.slurm import _get_system_partition_info, get_default_partition, validate
from smartsim.wlm.slurm import (
_get_system_partition_info,
get_default_partition,
validate,
)

# The tests in this file belong to the group_b group
pytestmark = pytest.mark.group_b
Expand Down
Loading