Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove Long Deprecated SmartSim Modules #514

Merged
merged 6 commits into from
Mar 14, 2024
Merged

Remove Long Deprecated SmartSim Modules #514

merged 6 commits into from
Mar 14, 2024

Conversation

amandarichardsonn
Copy link
Contributor

No description provided.

@amandarichardsonn amandarichardsonn changed the title Deprecate Remove Long Deprecated SmartSim Modules Mar 11, 2024
@codecov Codecov
Copy link

codecov bot commented Mar 12, 2024 •
edited
Loading

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 90.75%. Comparing base (3c271f3) to head (eb20468).

Additional details and impacted files

Impacted file tree graph

@@             Coverage Diff             @@
##           develop     #514      +/-   ##
===========================================
+ Coverage    90.70%   90.75%   +0.05%     
===========================================
  Files           60       60              
  Lines         3839     3839              
===========================================
+ Hits          3482     3484       +2     
+ Misses         357      355       -2

see 1 file with indirect coverage changes

al-rigazzi
al-rigazzi approved these changes Mar 13, 2024
View reviewed changes
Copy link
Collaborator

@al-rigazzi al-rigazzi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, pending review by issue reporter!

MattToast
MattToast requested changes Mar 13, 2024
View reviewed changes
Copy link
Member

@MattToast MattToast left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

One small ask: since this is a public API break, can we call it out in the changlog? I don't want to forget to do it at release time!

@amandarichardsonn
Copy link
Contributor Author

amandarichardsonn commented Mar 13, 2024 •
edited
Loading

@MattToast I forgot to link under detailed notes on the changelog b4 merging in the SmartSim documentation, that correction is in the read-yaml PR so ignore!

MattToast
MattToast approved these changes Mar 14, 2024
View reviewed changes
Copy link
Member

@MattToast MattToast left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! Thanks for cleaning up the SmartSim repo!

@amandarichardsonn amandarichardsonn merged commit 6660efc into CrayLabs:develop Mar 14, 2024
42 checks passed
@amandarichardsonn amandarichardsonn deleted the deprecate branch March 14, 2024 17:01
@amandarichardsonn amandarichardsonn added API break Issues that include incompatible API changes area: api Issues related to API changes repo: smartsim Issues related to SmartSim infrastructure library short task Issues that can be completed and reviewed quickly type: chore Issue outside of general development labels Apr 25, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@al-rigazzi al-rigazzi al-rigazzi approved these changes

@MattToast MattToast MattToast approved these changes

Assignees
No one assigned
Labels
API break Issues that include incompatible API changes area: api Issues related to API changes repo: smartsim Issues related to SmartSim infrastructure library short task Issues that can be completed and reviewed quickly type: chore Issue outside of general development
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@amandarichardsonn @al-rigazzi @MattToast