Fix the dbmodel and dbscript test errors #313
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
collisions by setting the number of nodes and tasks to be one. This will cause warnings for local test launching, but the tests will still successfully pass.
MattToast
approved these changes
Jul 3, 2023
Codecov Report
Additional details and impacted files@@ Coverage Diff @@
## develop #313 +/- ##
========================================
Coverage 87.00% 87.00%
========================================
Files 59 59
Lines 3518 3518
========================================
Hits 3061 3061
Misses 457 457 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In PR 304 (#304), the DB model and script tests were updated to enable testing on workload managers. However, these tests were not constrained to run on only one node and one process during the update. As a result, each SmartSim
modelandEnsemblemember is run with a generic run command (e.g.srun) that results in multiple, identical clones of the test entity running on each compute node (e.g. in a generic slurm interactive allocation with three nodes, asruncommand without-Nand/or-narguments will launch the test script on three compute nodes). This oversight causes a combination of key collisions that results in sporadic test failures. This PR addresses those test failures.