Update add_ml_model and add_script #304
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
Additional details and impacted files@@ Coverage Diff @@
## develop #304 +/- ##
===========================================
- Coverage 87.44% 86.96% -0.49%
===========================================
Files 59 59
Lines 3481 3482 +1
===========================================
- Hits 3044 3028 -16
- Misses 437 454 +17
|
MattToast
approved these changes
Jun 15, 2023
smartsim/entity/model.py
Outdated
| @@ -462,7 +468,9 @@ def add_function( | |||
| :type script_path: str, optional | |||
There was a problem hiding this comment.
Looks like :param script: and :param script_path: are copy/paste errors from back in the day. Can you update these while you are here
|
Thanks for the great feedback. I'm going to move this PR to "draft" because I was looking at the code more and see that the tests for these functions were not being tested on GPU for WLM tests when device was set to GPU. I'll address your feedback and a few other things and change the status back when it is ready for review. |
mellis13
changed the title
MattToast
requested changes
Jun 22, 2023
mellis13
force-pushed
the
model_doc_update
branch
from
4c6d8f3
to
a274906
Compare
MattToast
approved these changes
Jun 26, 2023
mellis13
force-pushed
the
model_doc_update
branch
from
9284dae
to
f169f74
Compare
mellis13
force-pushed
the
model_doc_update
branch
from
a59ff32
to
af38806
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR addresses incorrect or inconsistent behavior in the
Model.add_ml_model(),Model.add_script()andModel.add_function()API. The following changes are included in this PR:loinstead ofipogif0