Upgrade to Wasmvm 0.14.0 beta3 #487
Conversation
Bumps [github.com/CosmWasm/wasmvm](https://github.com/CosmWasm/wasmvm) from 0.14.0-beta1 to 0.14.0-beta2. - [Release notes](https://github.com/CosmWasm/wasmvm/releases) - [Changelog](https://github.com/CosmWasm/wasmvm/blob/main/CHANGELOG.md) - [Commits](CosmWasm/wasmvm@v0.14.0-beta1...v0.14.0-beta2) Signed-off-by: dependabot-preview[bot] <support@dependabot.com>
Codecov Report
@@ Coverage Diff @@
## master #487 +/- ##
==========================================
+ Coverage 56.78% 57.01% +0.23%
==========================================
Files 41 41
Lines 4392 4411 +19
==========================================
+ Hits 2494 2515 +21
- Misses 1687 1688 +1
+ Partials 211 208 -3
|
| ReplyOn: wasmvmtypes.ReplySuccess, | ||
| } | ||
| if !tc.replyOnSuccess { | ||
| subMsg.ReplyOn = wasmvmtypes.ReplyError |
There was a problem hiding this comment.
nice to have: you can avoid the if and increase readability if you replace the replyOnSuccess bool by the replyOn value. But no need to change this.
There was a problem hiding this comment.
I wanted to, but it requires me to use a private type in the struct... hmmmm
I made the type private to keep it a closed enum (there are only 3 public instances of it), rather than allow anyone to create new ReplyOn types.
go.sum
Outdated
| @@ -19,6 +19,10 @@ github.com/ChainSafe/go-schnorrkel v0.0.0-20200405005733-88cbf1b4c40d h1:nalkkPQ | |||
| github.com/ChainSafe/go-schnorrkel v0.0.0-20200405005733-88cbf1b4c40d/go.mod h1:URdX5+vg25ts3aCh8H5IFZybJYKWhJHYMTnf+ULtoC4= | |||
| github.com/CosmWasm/wasmvm v0.14.0-beta1 h1:ASqXB/2D8CEBmAI/uljRw6eEMbeKXPQtL/wZzKXZGGA= | |||
| github.com/CosmWasm/wasmvm v0.14.0-beta1/go.mod h1:Id107qllDJyJjVQQsKMOy2YYF98sqPJ2t+jX1QES40A= | |||
| github.com/CosmWasm/wasmvm v0.14.0-beta2 h1:8bLLNaxj796qUwu6UuQDbqpMV9zPpxG3lNZZbswNdOo= | |||
| github.com/CosmWasm/wasmvm v0.14.0-beta2/go.mod h1:Id107qllDJyJjVQQsKMOy2YYF98sqPJ2t+jX1QES40A= | |||
There was a problem hiding this comment.
next go mod tidy run will drop the beta1 +2.
| @@ -3,7 +3,7 @@ module github.com/CosmWasm/wasmd | |||
| go 1.15 | |||
|
|
|||
| require ( | |||
| github.com/CosmWasm/wasmvm v0.14.0-beta1 | |||
| github.com/CosmWasm/wasmvm v0.14.0-beta3 | |||
There was a problem hiding this comment.
There is a reference in the Dockerfile that we need to update. 🕵️
There was a problem hiding this comment.
Will do that and go mod tidy
|
Ah, I will do a PR to this branch for |
Closes #479
ReplyOnfield to all SubMsg testsReplyOnother thanAlways@alpe This is working. Can you add support for BankMsg::Burn on this PR or merge this PR (if it looks good) and make that in another PR? I think you are much faster with your new handler design, I am not sure exactly where to add it properly.