Handle wasmvm Burn message #489
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## wasmvm-0.14.0-beta3 #489 +/- ##
=======================================================
+ Coverage 56.89% 56.97% +0.07%
=======================================================
Files 41 41
Lines 4396 4411 +15
=======================================================
+ Hits 2501 2513 +12
- Misses 1687 1689 +2
- Partials 208 209 +1
|
ethanfrey
approved these changes
Apr 13, 2021
| @@ -15,8 +15,8 @@ WORKDIR /code | |||
| COPY . /code/ | |||
|
|
|||
| # See https://github.com/CosmWasm/wasmvm/releases | |||
| ADD https://github.com/CosmWasm/wasmvm/releases/download/v0.14.0-beta1/libwasmvm_muslc.a /lib/libwasmvm_muslc.a | |||
| RUN sha256sum /lib/libwasmvm_muslc.a | grep b69cf9ffbdfb2f1bd1e6f730ecee1eb0d06a1473840a24709aec7a7df5907d45 | |||
| ADD https://github.com/CosmWasm/wasmvm/releases/download/v0.14.0-beta3/libwasmvm_muslc.a /lib/libwasmvm_muslc.a | |||
There was a problem hiding this comment.
Ah, you fixed this. Thank you
| @@ -181,6 +181,7 @@ var ( | |||
| stakingtypes.NotBondedPoolName: {authtypes.Burner, authtypes.Staking}, | |||
| govtypes.ModuleName: {authtypes.Burner}, | |||
| ibctransfertypes.ModuleName: {authtypes.Minter, authtypes.Burner}, | |||
| wasm.ModuleName: {authtypes.Burner}, | |||
|
|
||
| var _ Messenger = MessageHandlerFunc(nil) | ||
|
|
||
| // MessageHandlerFunc is a helper to construct simple function based message handler |
| if err != nil { | ||
| return nil, nil, err | ||
| } | ||
| if err := burner.SendCoinsFromAccountToModule(ctx, contractAddr, types.ModuleName, coins); err != nil { |
There was a problem hiding this comment.
Ah, it is a two step process? Only module accounts can burn.
Glad you took this on and not me. So many gotchas
| require.NoError(t, err) | ||
| example := InstantiateHackatomExampleContract(t, ctx, keepers) // with deposit of 100 stake | ||
|
|
||
| specs := map[string]struct { |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Continue #479