-
Notifications
You must be signed in to change notification settings - Fork 418
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add IBC Ping Pong contract demo #259
Conversation
aa2bea0
to
cabc206
Compare
Codecov Report
@@ Coverage Diff @@
## alex_ibc_spike2d #259 +/- ##
====================================================
+ Coverage 17.08% 17.43% +0.35%
====================================================
Files 36 36
Lines 11557 11516 -41
====================================================
+ Hits 1974 2008 +34
+ Misses 9483 9406 -77
- Partials 100 102 +2
Continue to review full report at Codecov.
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Start review, cover internal package.
Will do follow up review on ping_pong test
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Comments on relay test
}, 0, nil | ||
} | ||
|
||
otherCount := receivedBall[counterParty(p.actor)] |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Let's add a max hits (3 or 4) and if this is higher, then we return IBCPacketReceiveResponse
with a "failed" response. In this case, we do not initiate another round. It will allow us to test error handling in acknowledge.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good to merge except for some errand text renamings.
Two things needed in follow-up PRs:
- Run the ping pong until maxValue, so we get an failure and stop. This failure should be properly relayed and not return an error to the ibc handler (and rollback the tx).
- Try version negotiation (ADR25) and see if that works or not - if not, make an issue about it. This can be done separately in a minor PR so we can link the failing code without blocking on it being fixed.
Also submit the issue about ordered channels not working (maybe linking to another intentionally broken pr)
…ster * remotes/gaia/master: (38 commits) Merge PR CosmWasm#259: Bump SDK master commit Exec go mod tidy (CosmWasm#267) Merge PR CosmWasm#265: add version v2.0.5 to CHANGELOG Fix broken link in delegator guide (CosmWasm#262) docs: removed redundant readme.md (CosmWasm#261) Merge PR CosmWasm#258: Bump github.com/spf13/viper from 1.6.1 to 1.6.2 Merge PR CosmWasm#250: Docs-update Merge PR CosmWasm#256: Bump github.com/pkg/errors from 0.9.0 to 0.9.1 Merge PR CosmWasm#255: Bump github.com/pkg/errors from 0.8.1 to 0.9.0 Merge PR CosmWasm#253: Bump SDK master commit Merge PR CosmWasm#252: v2.0.4 Changelog Merge PR CosmWasm#249: docker image build and upload for release tags Merge PR CosmWasm#247: Update SDK Commit & Update CLI Doc Merge PR CosmWasm#246: Update Archive page with explorers Merge PR CosmWasm#245: archives Bump SDK commit to the latest master (CosmWasm#239) Merge PR CosmWasm#215: Update simulation tests Update join-mainnet.md (CosmWasm#229) Incorporate SDK's latest changes (CosmWasm#227) Merge PR CosmWasm#221: Hide unnecessarily exported function to better coverage report ...
relay_pingpong_test.go
as happy path for Complete IBC Mock testing #255