0.9.1 to cosmos stargate cli fixes #249
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## 0.9.1_to_cosmos-sdk-0.39-master #249 +/- ##
===================================================================
+ Coverage 19.80% 19.91% +0.11%
===================================================================
Files 25 25
Lines 6419 6428 +9
===================================================================
+ Hits 1271 1280 +9
Misses 5079 5079
Partials 69 69
Continue to review full report at Codecov.
|
ethanfrey
approved these changes
Aug 10, 2020
There was a problem hiding this comment.
Nice cleanup. Good to merge.
Two questions:
- This works to launch an app? Or is there an issue in genesis parsing still? (Please add that to the TODO in the stargate tracking branch, so we can keep track of what needs to be done).
- Is there a reason we cannot just copy the simapp/params into our app and use it. I would prefer not to import anything from simapp directly, and just use that as a model for what we want in our app dir.
Unfortunately not. It still fails with |
zemyblue
pushed a commit
to Finschia/wasmd
that referenced
this pull request
Jan 2, 2023
zemyblue
pushed a commit
to Finschia/wasmd
that referenced
this pull request
Jan 2, 2023
…ster * remotes/gaia/master: (38 commits) Merge PR CosmWasm#259: Bump SDK master commit Exec go mod tidy (CosmWasm#267) Merge PR CosmWasm#265: add version v2.0.5 to CHANGELOG Fix broken link in delegator guide (CosmWasm#262) docs: removed redundant readme.md (CosmWasm#261) Merge PR CosmWasm#258: Bump github.com/spf13/viper from 1.6.1 to 1.6.2 Merge PR CosmWasm#250: Docs-update Merge PR CosmWasm#256: Bump github.com/pkg/errors from 0.9.0 to 0.9.1 Merge PR CosmWasm#255: Bump github.com/pkg/errors from 0.8.1 to 0.9.0 Merge PR CosmWasm#253: Bump SDK master commit Merge PR CosmWasm#252: v2.0.4 Changelog Merge PR CosmWasm#249: docker image build and upload for release tags Merge PR CosmWasm#247: Update SDK Commit & Update CLI Doc Merge PR CosmWasm#246: Update Archive page with explorers Merge PR CosmWasm#245: archives Bump SDK commit to the latest master (CosmWasm#239) Merge PR CosmWasm#215: Update simulation tests Update join-mainnet.md (CosmWasm#229) Incorporate SDK's latest changes (CosmWasm#227) Merge PR CosmWasm#221: Hide unnecessarily exported function to better coverage report ...
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
3322e26The encoding issues on
wasmd startare not solved with this, yet. Waiting for sdk updates to apply/ adopt them.