-
Notifications
You must be signed in to change notification settings - Fork 353
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Issue#674 #680
Issue#674 #680
Conversation
…dded system method so that both old and new modules can use the system as well as migrate function. Introduced a new Enum called SystemMsg.
…eryResponse in std/lib.rs
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you for your contribution. I hope you had the chance to get familiar with the code base a little bit.
#674 is a ticket that was not very mature when you started working on it. We closed it now and created a few follow-up tickets.
Would you like to work on #690? This has a smaller scope and it is very clear what we want. Just let me know, then I assign you there.
@@ -17,7 +17,7 @@ pub struct InitMsg { | |||
pub beneficiary: HumanAddr, | |||
} | |||
|
|||
/// MigrateMsg allows a priviledged contract administrator to run | |||
/// MigrateMsg allows a privileged contract administrator to run |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
👍
@@ -18,4 +19,5 @@ pub use handle::{HandleResponse, HandleResult}; | |||
pub use init::{InitResponse, InitResult}; | |||
pub use migrate::{MigrateResponse, MigrateResult}; | |||
pub use query::{QueryResponse, QueryResult}; | |||
pub use system::{SystemResponse, SystemResult as SystemRes}; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Ahh, good to know SystemResult
already exists. We should keep that in mind and maybe find a better name for "system".
Yeah please, That would be great! |
Thank you for your contribution. As discussed in #674 we keep the entry points separate. Closing. |
issue: #674
migrate
entry point with more generalsystem
#674. Added system functionality along with the migrate. So that both old and new models can use the migrate functionality._info: MessageInfo
parameter forpub fn system()
. Changed theSystemMsg
fromInitMsg
likestruct
toHandleMsg
likeenum
.match
While assigning theMigrateMsg.verifier
toconfig.verifier
inpub fn system
.system.rs
inpackages/src/results/
mod in order to provide return value.StdResult<SystemResponse>
.Before we can merge this PR, please make sure that all the following items have been
checked off. If any of the checklist items are not applicable, please leave them but
write a little note why.
Please review this PR @ethanfrey