Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Don't pass MessageInfo to migrate #690

Closed
1 of 2 tasks
ethanfrey opened this issue Jan 5, 2021 · 4 comments · Fixed by #709 or #764
Closed
1 of 2 tasks

Don't pass MessageInfo to migrate #690

ethanfrey opened this issue Jan 5, 2021 · 4 comments · Fixed by #709 or #764
Assignees
Milestone

Comments

@ethanfrey
Copy link
Member

ethanfrey commented Jan 5, 2021

Follow up from #674 (comment)

We currently do not allow sending funds in the migrate command in wasmd, and the sender is meaningless, as this is a permissioned call, so we never need to check it anyway.

I propose to simplify this and use the same function signature as query. In fact, other "priviledged" calls, like handling ibc messages, also likely do not need this field.


@ethanfrey ethanfrey added this to the 0.14.0 milestone Jan 5, 2021
@webmaster128
Copy link
Member

Interesting. This means it is completly up to the chain to decide who has permission to migrate. And there can be permissioning schemes that work different than the admin field we came up with.

@webmaster128
Copy link
Member

For everything the MessageInfo::sender was used for, we can also use the migrate message, like here:

pub struct MigrateMsg {
    pub payout: HumanAddr,
}

@webmaster128
Copy link
Member

@venkattejaRaavi it seems like I cannot assign you here. But feel free to give this ticket a try. Let me know when something is unclear.

@webmaster128
Copy link
Member

webmaster128 commented Jan 20, 2021

Re-opening since this really needs a proper CHANGELOG and MIGRATING entry. But I can do that.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
2 participants