-
Notifications
You must be signed in to change notification settings - Fork 353
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Don't pass MessageInfo to migrate #690
Comments
Interesting. This means it is completly up to the chain to decide who has permission to migrate. And there can be permissioning schemes that work different than the admin field we came up with. |
For everything the MessageInfo::sender was used for, we can also use the migrate message, like here:
|
@venkattejaRaavi it seems like I cannot assign you here. But feel free to give this ticket a try. Let me know when something is unclear. |
Re-opening since this really needs a proper CHANGELOG and MIGRATING entry. But I can do that. |
Follow up from #674 (comment)
We currently do not allow sending funds in the migrate command in wasmd, and the sender is meaningless, as this is a permissioned call, so we never need to check it anyway.
I propose to simplify this and use the same function signature as query. In fact, other "priviledged" calls, like handling ibc messages, also likely do not need this field.
The text was updated successfully, but these errors were encountered: