fix(authentication): email dependent app route registration #257
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR simplifies
Authentication
's app route registration process.Any
Email
-dependent routes are now registered onceEmail
is online and serving andAuthentication
no longer attempts to handleEmail
module going offline.Fixes an issue where email serving status would not propagate down to handlers, resulting in incorrect route registration.
I'm using a timeout so as not to register routes twice whenever
Email
-dependent functionality is enabled and the module is already serving at the timeAuthentication
is being brought up.There's a couple of issues currently preventing this from working as expected, but they're both unrelated to
Authentication
and shouldn't require further changes on this side once resolved:Core
'swatchModules()
gRPC stream is restarted whenever Router goes online, meaning bringing upEmail
straight afterRouter
without restartingAuthentication
won't register additional routes.gRPC-sdk
'smonitorModule()
does not await for the module to become available before first executing the provided callback (fix(grpc-sdk): monitorModule() not awaiting module before first callback call #256)The first issue is related to Core temporarily going offline while registering its HTTP routes via
Router
.I've already opened a PR for the second one.
What kind of change does this PR introduce?
Does this PR introduce a breaking change?
The PR fulfills these requirements:
main
branchfix #xxx
, where "xxx" is the issue number)