Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(authentication): implement change email #255

Merged
merged 8 commits into from
Jul 25, 2022
Merged

feat(authentication): implement change email #255

merged 8 commits into from
Jul 25, 2022

Conversation

ChrisPdgn
Copy link
Contributor

@ChrisPdgn ChrisPdgn commented Jul 21, 2022

What kind of change does this PR introduce?

  • Bugfix
  • Feature
  • Code style update
  • Refactor
  • Build-related changes
  • Other (please describe)

Does this PR introduce a breaking change?

  • Yes
  • No

Other information:
Verification is now done through hooks, after bugfix logically an email will be sent to user

modules/authentication/src/handlers/local.ts Outdated Show resolved Hide resolved
modules/authentication/src/handlers/local.ts Outdated Show resolved Hide resolved
@kon14
Copy link
Contributor

kon14 commented Jul 21, 2022

This is going to have to be rebased against #257 (or vice-versa).

@ChrisPdgn ChrisPdgn requested a review from kon14 July 21, 2022 14:48
modules/authentication/src/handlers/local.ts Outdated Show resolved Hide resolved
modules/authentication/src/handlers/local.ts Outdated Show resolved Hide resolved
@kkopanidis kkopanidis merged commit 9ef6663 into main Jul 25, 2022
@kkopanidis kkopanidis deleted the change-email branch July 25, 2022 11:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants