Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Generic pallet #2

Merged
merged 2 commits into from
Jul 13, 2021
Merged

Generic pallet #2

merged 2 commits into from
Jul 13, 2021

Conversation

flipchan
Copy link
Contributor

from polka-47 ticket:
"Add a generic Pallet to our Runtime, test it, and configure it to add features in the future."

@flipchan flipchan requested a review from Br1ght0ne July 13, 2021 11:25
Br1ght0ne
Br1ght0ne approved these changes Jul 13, 2021
View reviewed changes
Copy link
Contributor

@Br1ght0ne Br1ght0ne left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

A few points to check:

  1. Do we still need pallets/template?
  2. Should we add pallets/cfgeneric to workspace Cargo.toml to match pallets/template? If we don't, it won't be built by the CI.

Other than that, LGTM. Good job @flipchan!

@bluewitch bluewitch merged commit 906cc96 into main Jul 13, 2021
haroldsphinx added a commit that referenced this pull request Oct 11, 2021
@haroldsphinx
# This is a combination of 2 commits.
6a2de6e 
# This is the 1st commit message:

Implement auto update feature using two approaches

# This is the commit message #2:

Implement auto update feature using two approaches
@seunlanlege seunlanlege deleted the generic-pallet branch October 26, 2021 11:07
haroldsphinx added a commit that referenced this pull request Jan 27, 2022
@haroldsphinx
# This is a combination of 5 commits.
3a55b92 
# This is the 1st commit message:

rebase

# This is the commit message #2:

rebase

# This is the commit message #3:

add origin

# This is the commit message #4:

Delete build-artifacts.yml
# This is the commit message #5:

rebase
haroldsphinx added a commit that referenced this pull request Jan 27, 2022
@haroldsphinx
# This is a combination of 7 commits.
06dd757 
# This is the 1st commit message:

rebase

# This is the commit message #2:

rebase

# This is the commit message #3:

add origin

# This is the commit message #4:

Delete build-artifacts.yml
# This is the commit message #5:

rebase

# This is the commit message #6:

fixes #535 (#553)

* fixes #535

* don't skip integration tests

* remove ref: main

* get github ref from action

* try base_ref

* try GITHUB_SHA

* GITHUB_REF_NAME

* back to GITHUB_SHA

* checkout pull request commit

* renamee to release-pipeline

* back to

Co-authored-by: Seun Lanlege <seunlanlege@gmail.com>
# This is the commit message #7:

fetch depth
haroldsphinx added a commit that referenced this pull request Jan 27, 2022
@haroldsphinx
# This is a combination of 5 commits.
622820d 
# This is the 1st commit message:

fetch depth

# The commit message #2 will be skipped:

# Update checkout action

# The commit message #3 will be skipped:

# Update checkout action

# The commit message #4 will be skipped:

# Update checkout action

# The commit message #5 will be skipped:

# Update checkout action
haroldsphinx added a commit that referenced this pull request Jan 27, 2022
@haroldsphinx
# This is a combination of 7 commits.
6dd4fb0 
# This is the 1st commit message:

fetch depth

# The commit message #2 will be skipped:

# Update checkout action

# The commit message #3 will be skipped:

# Update checkout action

# The commit message #4 will be skipped:

# Update checkout action

# The commit message #5 will be skipped:

# Update checkout action

# The commit message #6 will be skipped:

# Update checkout action

# The commit message #7 will be skipped:

# Update checkout action
haroldsphinx added a commit that referenced this pull request Jan 27, 2022
@haroldsphinx
# This is a combination of 10 commits.
6ae0f66 
# This is the 1st commit message:

fetch depth

# The commit message #2 will be skipped:

# Update checkout action

# The commit message #3 will be skipped:

# Update checkout action

# The commit message #4 will be skipped:

# Update checkout action

# The commit message #5 will be skipped:

# Update checkout action

# The commit message #6 will be skipped:

# Update checkout action

# The commit message #7 will be skipped:

# Update checkout action

# The commit message #8 will be skipped:

# Update checkout action

# The commit message #9 will be skipped:

# Update checkout action

# The commit message #10 will be skipped:

# Update checkout action
haroldsphinx added a commit that referenced this pull request Jan 27, 2022
@haroldsphinx
# This is a combination of 17 commits.
f4147aa 
# This is the 1st commit message:

fetch depth

# The commit message #2 will be skipped:

# Update checkout action

# The commit message #3 will be skipped:

# Update checkout action

# The commit message #4 will be skipped:

# Update checkout action

# The commit message #5 will be skipped:

# Update checkout action

# The commit message #6 will be skipped:

# Update checkout action

# The commit message #7 will be skipped:

# Update checkout action

# The commit message #8 will be skipped:

# Update checkout action

# The commit message #9 will be skipped:

# Update checkout action

# The commit message #10 will be skipped:

# Update checkout action

# The commit message #11 will be skipped:

# Update checkout action

# The commit message #12 will be skipped:

# Update checkout action

# The commit message #13 will be skipped:

# Update checkout action

# The commit message #14 will be skipped:

# Update checkout action

# The commit message #15 will be skipped:

# Update checkout action

# The commit message #16 will be skipped:

# Update checkout action

# The commit message #17 will be skipped:

# Update checkout action
gitbook-com bot pushed a commit that referenced this pull request Jan 31, 2022
@gitbook-bot
GitBook: [#2] No subject
9fe4c31
kollegian added a commit to kollegian/composable that referenced this pull request Apr 15, 2022
@kollegian
# This is a combination of 2 commits.
bd29a19 
# This is the 1st commit message:

BondedFinance Tests param fix and mint method opt

# The commit message ComposableFi#2 will be skipped:

# nonce issue fix and bondedfinanceUpdate WIP
dzmitry-lahoda added a commit that referenced this pull request Nov 8, 2022
@dzmitry-lahoda
# This is a combination of 2 commits.
37008d7 
# This is the 1st commit message:

common sence

Signed-off-by: Dzmitry Lahoda <dzmitry@lahoda.pro>

# This is the commit message #2:

dali compiles

Signed-off-by: Dzmitry Lahoda <dzmitry@lahoda.pro>
dzmitry-lahoda added a commit that referenced this pull request Nov 8, 2022
@dzmitry-lahoda
# This is a combination of 2 commits.
f7b8a36 
# This is the 1st commit message:

common sence

Signed-off-by: Dzmitry Lahoda <dzmitry@lahoda.pro>

# This is the commit message #2:

dali compiles

Signed-off-by: Dzmitry Lahoda <dzmitry@lahoda.pro>
dzmitry-lahoda added a commit that referenced this pull request Dec 14, 2022
@dzmitry-lahoda
# This is a combination of 13 commits.
648ec50 
# This is the 1st commit message:

lfs

# This is the commit message #2:

staging migration

Signed-off-by: Dzmitry Lahoda <dzmitry@lahoda.pro>

# This is the commit message #3:

picasso

# This is the commit message #4:

yamlgit add .git add .

# This is the commit message #5:

fmt; reuse; clean

Signed-off-by: Dzmitry Lahoda <dzmitry@lahoda.pro>

# This is the commit message #6:

trying replace nixops devnet

# This is the commit message #7:

fixed container

# This is the commit message #8:

zombies in compose

# This is the commit message #9:

getting routes

# This is the commit message #10:

ops mapping

# This is the commit message #11:

returned garbage for happy refactoring

# This is the commit message #12:

more

# This is the commit message #13:

revert
kkast pushed a commit to kkast/composable that referenced this pull request Feb 11, 2023
@PoisonPhang
PoC: Use Assets Transactor Router in Staking Rewards [PBL-352] [PBL-3…
e71ae30 
…51] (ComposableFi#2)

* Added dynamic asset creation to staking rewards

* Added assets system to Pablo

* Use dynamic fNFT ID within staking tests

* Use share asset ID as fNFT collection ID
g-la-d-os pushed a commit that referenced this pull request Apr 24, 2023
@JafarAz
Merge pull request #2 from obsessed-cake/centauri-updates-3
49bdc55 
Merge remote-tracking branch 'composable/main' into centauri-updates-2
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Br1ght0ne Br1ght0ne Br1ght0ne approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@flipchan @Br1ght0ne @bluewitch