integrate the price feed server #11
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@andor0 is there any chance you check this out please :)? |
hussein-aitlahcen
force-pushed
the
price-feed-integration
branch
4 times, most recently
from
abe08bb
to
7b07b67
Compare
hussein-aitlahcen
force-pushed
the
price-feed-integration
branch
3 times, most recently
from
4a6c93a
to
03ffb45
Compare
hussein-aitlahcen
force-pushed
the
price-feed-integration
branch
10 times, most recently
from
b02a2b7
to
8e306c3
Compare
hussein-aitlahcen
force-pushed
the
price-feed-integration
branch
from
8e306c3
to
3e7cc18
Compare
hussein-aitlahcen
force-pushed
the
price-feed-integration
branch
6 times, most recently
from
baaa634
to
a4631b0
Compare
hussein-aitlahcen
force-pushed
the
price-feed-integration
branch
from
a4631b0
to
19720b5
Compare
andor0
suggested changes
Aug 9, 2021
|
LGFM |
andor0
approved these changes
Aug 10, 2021
seunlanlege
pushed a commit
that referenced
this pull request
Sep 20, 2021
vault account fix & property tests precision
haroldsphinx
added a commit
that referenced
this pull request
Jan 27, 2022
# This is the 1st commit message: fetch depth # The commit message #2 will be skipped: # Update checkout action # The commit message #3 will be skipped: # Update checkout action # The commit message #4 will be skipped: # Update checkout action # The commit message #5 will be skipped: # Update checkout action # The commit message #6 will be skipped: # Update checkout action # The commit message #7 will be skipped: # Update checkout action # The commit message #8 will be skipped: # Update checkout action # The commit message #9 will be skipped: # Update checkout action # The commit message #10 will be skipped: # Update checkout action # The commit message #11 will be skipped: # Update checkout action # The commit message #12 will be skipped: # Update checkout action # The commit message #13 will be skipped: # Update checkout action # The commit message #14 will be skipped: # Update checkout action # The commit message #15 will be skipped: # Update checkout action # The commit message #16 will be skipped: # Update checkout action # The commit message #17 will be skipped: # Update checkout action
seunlanlege
added a commit
that referenced
this pull request
Oct 6, 2022
…tions (#11) * refactor traits * minor fix * fmt * clippy suggested fixes * test fixes * some fixes * deny docs * extra refactor of trait definitions * delegate all hashing to host functions * bump substrate and fix build errors * fix some comments * removed duplicate code in tests * make traits stateless * fix test issues * minor fix * export NodeUtils * minor fix * fix build error * make extrinsic proof a vector of bytes * check for wasm target * create test_utils * fixed flaky test issues * fix subxt at least * cargo fmt * fix tests * cargo test --nocapture * Bump version of composablefi/ci-linux docker image * use relay chain node url Co-authored-by: Seun Lanlege <seunlanlege@gmail.com> Co-authored-by: Andrey Orlov <aaorlov1@gmail.com>
dzmitry-lahoda
added a commit
that referenced
this pull request
Dec 14, 2022
# This is the 1st commit message: lfs # This is the commit message #2: staging migration Signed-off-by: Dzmitry Lahoda <dzmitry@lahoda.pro> # This is the commit message #3: picasso # This is the commit message #4: yamlgit add .git add . # This is the commit message #5: fmt; reuse; clean Signed-off-by: Dzmitry Lahoda <dzmitry@lahoda.pro> # This is the commit message #6: trying replace nixops devnet # This is the commit message #7: fixed container # This is the commit message #8: zombies in compose # This is the commit message #9: getting routes # This is the commit message #10: ops mapping # This is the commit message #11: returned garbage for happy refactoring # This is the commit message #12: more # This is the commit message #13: revert
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In this PR we update the price server to handle the current oracle implementation (pretty much implementing the exact interface it is expecting right now). I added a little bit of documentation as well so that anyone can try the end-to-end oracle<->server<->pyth pipeline.
We also fixed a little bug in the oracle pallet, we were trying to iterate over the assets by an index, while they were indexed by an arbitrary key (asset_id).
We refactored the code to separate the backend websocket fetch from the frontend api. We also extracted the pure logic from both the frontend and the backend module to write some tests.
I have one concern regarding how we handle the asset pair. Only a subset of the cartesian product (asset, asset) is valid, perhaps we should make a separate crate to handle these things as it will be pretty common to use them?
The nix script has been fixed, you should be able to run
nix-shell price-feed/run_pyth.nixand then use theruncommand to fire an instance ofpythdandpyth_tx. You can check their log, respectivelytail -f $PYTHD_LOGandtail -f $PYTH_TX_LOGfrom within the shell. The two instances are dropped on shell exit.