This repository has been archived by the owner on May 10, 2023. It is now read-only.
Only enable languages also enabled on Pontoon #558
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
MichaelKohler
pushed a commit
that referenced
this pull request
Nov 25, 2021
# [2.14.0](v2.13.1...v2.14.0) (2021-11-25) ### Bug Fixes * add note for addition process to language addition section (fixes [#474](#474)) ([#561](#561)) ([3ab0cf1](3ab0cf1)) * do not persist allLanguages, languages, router and review sentences from store (fixes [#550](#550)) ([#559](#559)) ([97e5217](97e5217)) ### Features * add UI language selector to profile (fixes [#533](#533)) ([#563](#563)) ([de59b70](de59b70)) * only enable languages also enabled on Pontoon ([#558](#558)) ([0da87d0](0da87d0)), closes [#534](#534)
|
🎉 This PR is included in version 2.14.0 🎉 The release is available on GitHub release Your semantic-release bot 📦🚀 |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR contains multiple parts to improve our language handling compared to Common Voice.
Relying on Pontoon for enabled languages
Until now we've had our own language list in Sentence Collector. This included languages that are not yet enabled on Common Voice, as we enabled the full ISO 639-1 list. This also meant that every time somebody requests a new locale we had to explicitly add it to Sentence Collector as well. With the changes here we are now fetching the enabled locales from Pontoon.
This means:
This implements all the changes from #534.
Only returning valid languages for profile
As we disable a few languages previously enabled and contributed to with the change above, we now also only return valid languages for the profile. This fixes the first part of #532. The second part of that will be handled with #474.
Cleanup of language data structure
We are now always passing the same language structure to the client from the backend, leading to quite some code cleanup in the client code. 🎉