Skip to content
This repository has been archived by the owner on May 10, 2023. It is now read-only.

Do not persist language list or sentences to review #550

Closed
MichaelKohler opened this issue Nov 18, 2021 · 1 comment
Closed

Do not persist language list or sentences to review #550

MichaelKohler opened this issue Nov 18, 2021 · 1 comment
Assignees
@MichaelKohler
Labels
enhancement New feature or request frontend invalid This doesn't seem right P2

Comments

@MichaelKohler
Copy link
Member

MichaelKohler commented Nov 18, 2021 •
edited
Loading

Currently we're persisting data in the Redux store that we do not need to persist. Having this data in the store makes it easy to access, but persistence is definitely not needed for the following:

  • languages
  • allLanguages
  • sentences (from the review)
  • router
@MichaelKohler MichaelKohler added enhancement New feature or request frontend P2 labels Nov 18, 2021
@MichaelKohler MichaelKohler added the invalid This doesn't seem right label Nov 18, 2021
@MichaelKohler MichaelKohler reopened this Nov 18, 2021
@MichaelKohler MichaelKohler self-assigned this Nov 19, 2021
MichaelKohler added a commit that referenced this issue Nov 20, 2021
@MichaelKohler
fix: do not persist allLanguages, languages, router and review senten…
fdd78a1 
…ces from store (fixes #550)
MichaelKohler pushed a commit that referenced this issue Nov 25, 2021
@semantic-release-bot
chore(release): 2.14.0
390bc6b 
# [2.14.0](v2.13.1...v2.14.0) (2021-11-25)

### Bug Fixes

* add note for addition process to language addition section (fixes [#474](#474)) ([#561](#561)) ([3ab0cf1](3ab0cf1))
* do not persist allLanguages, languages, router and review sentences from store (fixes [#550](#550)) ([#559](#559)) ([97e5217](97e5217))

### Features

* add UI language selector to profile (fixes [#533](#533)) ([#563](#563)) ([de59b70](de59b70))
* only enable languages also enabled on Pontoon ([#558](#558)) ([0da87d0](0da87d0)), closes [#534](#534)
@MichaelKohler
Copy link
Member Author

🎉 This issue has been resolved in version 2.14.0 🎉

The release is available on GitHub release

Your semantic-release bot 📦🚀

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@MichaelKohler MichaelKohler

Labels
enhancement New feature or request frontend invalid This doesn't seem right P2
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@MichaelKohler