Skip to content

feat: optional metrics config #98

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
wants to merge 2 commits into from
Closed

feat: optional metrics config #98

wants to merge 2 commits into from

Conversation

fbrv
Copy link
Contributor

@fbrv fbrv commented Sep 2, 2024 •
edited
Loading

Address #89, intermediate step before generating dynamic Kubernetes configuration from the CLI.

@fbrv fbrv requested a review from ltitanb September 2, 2024 09:07
@ltitanb ltitanb mentioned this pull request Sep 2, 2024
Merged
ltitanb
ltitanb reviewed Sep 2, 2024
View reviewed changes
Copy link
Collaborator

@ltitanb ltitanb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Lgtm, think we can close this as #99 has the same logic plus some other changes to tidy up files etc

@ltitanb
Copy link
Collaborator

ltitanb commented Sep 3, 2024

doing this in #99

@ltitanb ltitanb closed this Sep 3, 2024
@ltitanb ltitanb deleted the fb/optional-metrics-config branch September 3, 2024 09:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ltitanb ltitanb ltitanb left review comments

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@fbrv @ltitanb