Skip to content

Allow disabling Prometheus scraping config #89

@aimxhaisse

Description

@aimxhaisse

When using kubernetes, prometheus config is done by specifying annotations around running containers to tell the prometheus controller of kubernetes how to scrape config. As a result, we need a way in commit boost to just expose /metrics, and leave the rest to Kube.

Currently, we can't disable prometheus' config without crashing:

The application panicked (crashed).                                                                                                     
Message:  failed to load pbs config:                                                                                                    
   0: could not deserialize toml from string                                                                                            
   1: TOML parse error at line 10, column 1                                                                                             
   1:    |                                                                                                                              
   1: 10 | [metrics]                                                                                                                    
   1:    | ^^^^^^^^^                                                                                                                    
   1: missing field `prometheus_config`                                                                                                 
   1:                                                                                                                                   
                                                                                                                                        
Location:                                                                                                                               
   crates/common/src/config/utils.rs:15

Metadata

Metadata

Assignees

No one assigned

    Labels

    No labels
    No labels

    Type

    No type

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions