Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Support expansion of transformers ner models to include new concepts #519

Merged
merged 2 commits into from
Feb 14, 2025
Merged

Support expansion of transformers ner models to include new concepts #519

merged 2 commits into from
Feb 14, 2025

Conversation

baixiac
Copy link
Member

@baixiac baixiac commented Feb 12, 2025

This PR introduces methods that enable users to expand the transformers_ner model and its tokenizer by adding custom concepts for the downstream tasks, such as fine-tuning the DeID model.

@tomolopolis
Copy link
Member

Task linked: CU-8697v6qr2 Make the NerModel expandable with additional concept labels

mart-r
mart-r approved these changes Feb 12, 2025
View reviewed changes
Copy link
Collaborator

@mart-r mart-r left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think it looks good overall.

Though perhaps we want to add a log message regarding ignored concepts / labels upon adding? Up to you, though.

@baixiac baixiac merged commit e3913ab into master Feb 14, 2025
8 checks passed
@baixiac baixiac deleted the CU-8697v6qr2 branch February 14, 2025 10:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mart-r mart-r mart-r approved these changes

@tomolopolis tomolopolis Awaiting requested review from tomolopolis

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@baixiac @tomolopolis @mart-r