CU-8696v2j42: Add test to make sure per-cui counts are kept when creating folds #508
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mart-r
added a commit
that referenced
this pull request
Feb 12, 2025
…ting folds (#508) * CU-8696v2j42: Add test to make sure per-cui counts are kept when creating folds * CU-8696v2j42: Fix per annotation fold creation
mart-r
added a commit
that referenced
this pull request
Feb 12, 2025
…ting folds (#508) * CU-8696v2j42: Add test to make sure per-cui counts are kept when creating folds * CU-8696v2j42: Fix per annotation fold creation
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently, when splitting per-annotations, not all annotations are used.
In fact, only the annotations from the first few documents/projects would be used.
That is because for each fold, the number of annotations already used is not considered.
The PR adds a test to show that this is currently problematic (first commit).
And then introduces the relevant fix.