Remove duplicate chords

[AdamSEY]

Issues

Fixes #1209

Proposed changes

Remove duplicate chords

Checklist

• I consent that this change becomes part of alphaTab under it's current or any future open source license
• Changes are implemented
• Existing builds tests pass
• New tests were added

Further details

• This is a breaking change
• This change will require update of the documentation/website

[Danielku15]

The name is not a good indicator for uniqueness. The same chord (by name) might be played differently. That's why in #1209 I indicated that the name might be a good first check but we then need to check further based on the details within the chord.

This might be achieved by pre-computing a unique id in the Chord class based on the information (and we use it here) or we do the check here once and only if needed.

[AdamSEY]

I have made the required changes, please check again now the commits and let me know.

[AdamSEY]

I thought, we don't need to use JSON in chord.ts

[AdamSEY]

@Danielku15 Do you have any idea how to fix that, I believe in c# we could use String.Join but not sure why it's not being used in the translation process.

[Danielku15]

@AdamSEY Sorry for the long delay here. I made some modifications and now looks all good. Thanks for the contribution.

In such cases where a new API from JavaScript is used which might not exist in C# or Kotlin, we have three options: try to eliminate the use of the new API and go back to the basics, adjust the transpiler which translates TypeScript to XX to handle the special case or simply add the API in the target language (via extensions or helper methods which are implemented in each platform specifically). The extension is what I've done in this case: Simply adding an extension method to have something like a listOfStrings.Join("Separator") also in C# available. Kotlin has a .join() built in that's why it worked there.

Can be a bit tricky at the beginning.