Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Equal chords should only be listed once in the chord diagrams. #1209

Closed
Danielku15 opened this issue Jul 3, 2023 · 0 comments · Fixed by #1216
Closed

Equal chords should only be listed once in the chord diagrams. #1209

Danielku15 opened this issue Jul 3, 2023 · 0 comments · Fixed by #1216
Assignees
@Danielku15
Labels
area-core Related to some core parts of alphaTab area-file-formats Related to supported file formats area-rendering Everything related to the rendering platform-all Affects all platforms state-accepted This is a valid topic to work on.

Comments

@Danielku15
Copy link
Member

Like Reported here we should only list Chords once if they are equal.

We currently treat chords as unique via the chord ID: https://github.com/CoderLine/alphaTab/blob/develop/src/rendering/layout/ScoreLayout.ts#L212

We could either change this to check better whether the chords are the same (first check by name, then check details) or we add something to the model which computes this already (e.g. a unique ID based on name + strings).
@Danielku15 Danielku15 added 🚀 type-improvement area-file-formats Related to supported file formats area-rendering Everything related to the rendering state-accepted This is a valid topic to work on. platform-all Affects all platforms area-core Related to some core parts of alphaTab labels Jul 3, 2023
@Danielku15 Danielku15 self-assigned this Jul 3, 2023
AdamSEY added a commit to AdamSEY/alphaTab that referenced this issue Jul 4, 2023
@AdamSEY
Remove duplicate chords based on this issue: CoderLine#1209
eba83f2
@AdamSEY AdamSEY mentioned this issue Jul 4, 2023
Merged
6 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@Danielku15 Danielku15

Labels
area-core Related to some core parts of alphaTab area-file-formats Related to supported file formats area-rendering Everything related to the rendering platform-all Affects all platforms state-accepted This is a valid topic to work on.
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Remove duplicate chords AdamSEY/alphaTab
1 participant
@Danielku15